Skip to content

chore(dashboard): successor carryover pending in #1367 - #1381

Draft
seonghobae wants to merge 9 commits into
developfrom
palette-ux-file-upload-proxy-10215990310433498519
Draft

seonghobae wants to merge 9 commits into
developfrom
palette-ux-file-upload-proxy-10215990310433498519

Conversation

@seonghobae

@seonghobae seonghobae commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

상태: successor carryover 검증 대기

이 PR의 원래 변경은 파일 업로드 native input을 숨기고 visible proxy button으로 클릭을 위임하는 동작이었습니다. 동일한 유효 동작과 더 강한 회귀 계약은 canonical writer #1367에 있습니다.

보존·배제 근거

  • 원래 head: be8582e209f8d9438e053ada8f52b215ce6be086
  • 첫 복원 head: 2c45dd6d8b8850be53e31f92802563139c0cfe31
  • stale replay head: d89c6685ef9fbe7f4ee355275f5a18a9000b5e0b
  • 현재 복구 head: 4e84b5fe6b2f5135ce9cb5e732ceedbf7e8656e8
  • protected base: 2949d30718752ea5915c7713ba227e8c19d9e5bf
  • 첫 복원 뒤 동시 자동 커밋이 원래 세 파일을 byte-identical하게 재도입했습니다. force push/rebase 없이 다시 일반 자식 커밋 3개로 protected-base blob을 복구하여 원본·동시 커밋·리뷰 근거를 모두 보존했습니다.
  • 현재 base 비교: ahead 8 / behind 0 / changed files 0.
  • #1381의 전역 문자열 테스트는 파일 input에서 sr-only 또는 tabindex=-1이 빠져도 다른 요소 때문에 통과할 수 있다는 리뷰 결함이 있었습니다. 해당 thread는 현재 diff에서 outdated이며 근거 보존을 위해 임의 resolve하지 않았습니다.
  • #1367은 실제 input/button 속성을 HTML parser로 대상화하고, 문서의 실제 IIFE를 Node controlled DOM에서 실행해 handler 등록과 단 한 번의 native input click 위임을 검증합니다.
  • .jules/palette.md 학습문과 그 문장을 grep하는 테스트는 제품 동작·검출 계약이 아니므로 successor delta로 채택하지 않았습니다.

Exact-head Checks / merge 정책

현재 head 4e84b5fe6b2f5135ce9cb5e732ceedbf7e8656e8에서 6개 workflow run의 8개 job이 모두 terminal failure이지만 전부 steps=null입니다. 대표 Tests jobs 111143537720, 111143537739의 로그 다운로드도 BlobNotFound입니다. 소스 verdict가 아니라 runner/admission 결함이며 canonical RCA는 ContextualWisdomLab/.github#2356입니다.

Draft/open을 유지합니다. #1367의 exact-head Checks와 current-head review가 GREEN이 되기 전에는 complete successor carryover로 간주하지 않으며, blind rerun·Ready 전환·gate 우회·merge·Close를 하지 않습니다.

- index.html의 native 파일 입력을 숨기고 접근성 있는 proxy 버튼으로 대체합니다.
- proxy 버튼은 JS event listener를 통하여 동작합니다.
- .jules/palette.md에 a11y 관련 학습 내용을 기록하였습니다.
- 관련 테스트를 수정/추가하였습니다.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment on lines +313 to +314
assert 'class="sr-only"' in html and 'tabindex="-1"' in html and 'aria-hidden="true"' in html
assert 'type="file"' in html and 'id="file"' in html

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Upload accessibility test checks unrelated elements

The test searches the entire document for each attribute. Existing elements already use sr-only and tabindex="-1", so removing either from the file input can leave this test green.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@seonghobae
seonghobae marked this pull request as draft October 3, 2026 06:01
@seonghobae seonghobae changed the title 🎨 Palette: 파일 업로드 proxy 버튼 개선 chore(dashboard): successor carryover pending in #1367 Oct 3, 2026
- index.html의 native 파일 입력을 숨기고 접근성 있는 proxy 버튼으로 대체합니다.
- proxy 버튼은 JS event listener를 통하여 동작합니다.
- .jules/palette.md에 a11y 관련 학습 내용을 기록하였습니다.
- 관련 테스트를 수정/추가하였습니다.

Copy link
Copy Markdown
Contributor Author

Canonical successor advanced; zero-diff hold preserved

Fresh re-read confirms this PR remains Draft/open/mergeable at exact head 4e84b5fe6b2f5135ce9cb5e732ceedbf7e8656e8 with an empty protected-base diff (0 changed files).

Canonical writer #1367 advanced through ordinary test-first commits:

  • RED 54e49b84cb132965584a6e99a4b9b42c88af2ab8 targets the valid missing action-token contract;
  • GREEN current head 1f620b2b4aac9d3a46239aee53719f017c789875 replaces undefined ghost with existing primary-action, preserving the targeted attribute parser and executed click-delegation regression.

The stale current-head approvals on #1367 remain non-authoritative, and its fresh eight hosted jobs again ended before execution with steps=null / sampled BlobNotFound logs. Therefore #1381 stays Draft/open as evidence-preserved pending carryover verification; no Ready toggle, rerun, merge, bypass, or Close was performed. The outdated Devin thread remains visible as the original evidence for the false-negative test boundary now covered by #1367.

- index.html의 native 파일 입력을 숨기고 접근성 있는 proxy 버튼으로 대체합니다.
- proxy 버튼은 JS event listener를 통하여 동작합니다.
- .jules/palette.md에 a11y 관련 학습 내용을 기록하였습니다.
- 관련 테스트를 수정/추가하였습니다.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant