Skip to content

๐ŸŽจ Palette: ์™ธ๋ถ€ ๋งํฌ ์ ‘๊ทผ์„ฑ ๋ฐ ๋ ˆ์ด์•„์›ƒ ๊ฐœ์„  - #1371

Closed
seonghobae wants to merge 2 commits into
developfrom
palette-a11y-external-links-405934411580926250
Closed

seonghobae wants to merge 2 commits into
developfrom
palette-a11y-external-links-405934411580926250

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

๐Ÿ’ก What: target="_blank" ์™ธ๋ถ€ ๋งํฌ์— ์‹œ๊ฐ ์žฅ์• ์ธ์„ ์œ„ํ•œ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ๊ฒฝ๊ณ  ํ…์ŠคํŠธ(.sr-only)์™€ ๋น„์‹œ๊ฐ ์žฅ์• ์ธ์„ ์œ„ํ•œ ์‹œ๊ฐ์  ์•„์ด์ฝ˜(aria-hidden="true")์„ ์ถ”๊ฐ€ํ•˜๊ณ , ๊ธด ํ…์ŠคํŠธ(์˜ˆ: URL)๊ฐ€ ๋ ˆ์ด์•„์›ƒ์„ ๊นจ์ง€ ์•Š๋„๋ก ๋‹จ์–ด ์ค„๋ฐ”๊ฟˆ(word-break) ์œ ํ‹ธ๋ฆฌํ‹ฐ ํด๋ž˜์Šค๋ฅผ ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Why: ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๋Š” ์™ธ๋ถ€ ๋งํฌ๊ฐ€ ์ƒˆ ํƒญ์—์„œ ์—ด๋ฆด ๋•Œ ๋ช…์‹œ์ ์ธ ์•ˆ๋‚ด๊ฐ€ ์—†์œผ๋ฉด ํ˜ผ๋ž€์„ ๊ฒช์„ ์ˆ˜ ์žˆ์œผ๋ฉฐ, ์‹œ๊ฐ์  ์‚ฌ์šฉ์ž ์—ญ์‹œ ์•„์ด์ฝ˜ ๋“ฑ์˜ ๋‹จ์„œ๊ฐ€ ์—†์œผ๋ฉด ๋งํฌ ํด๋ฆญ ๊ฒฐ๊ณผ๋ฅผ ์˜ˆ์ธกํ•˜๊ธฐ ์–ด๋ ต์Šต๋‹ˆ๋‹ค. ๋˜ํ•œ ๊ธด URL ํ…์ŠคํŠธ๊ฐ€ ์ค„๋ฐ”๊ฟˆ๋˜์ง€ ์•Š๊ณ  ๋ ˆ์ด์•„์›ƒ์„ ๋ฒ—์–ด๋‚˜๋Š” ๋ฌธ์ œ๋ฅผ ๋ฐฉ์ง€ํ•˜์—ฌ ์ „๋ฐ˜์ ์ธ ๋Œ€์‹œ๋ณด๋“œ ์‚ฌ์šฉ์„ฑ๊ณผ ์ ‘๊ทผ์„ฑ์„ ํ–ฅ์ƒ์‹œํ‚ค๊ธฐ ์œ„ํ•จ์ž…๋‹ˆ๋‹ค.
โ™ฟ Accessibility:

  • ์ƒˆ ํƒญ์—์„œ ์—ด๋ฆฌ๋Š” ๋งํฌ์— ์‹œ๊ฐ์ ์œผ๋กœ ์ˆจ๊ฒจ์ง„ (opens in a new tab) ํ…์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๋ฅผ ๋ฐฐ๋ คํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์‹œ๊ฐ์  ์•„์ด์ฝ˜์€ aria-hidden="true"๋กœ ์ฒ˜๋ฆฌํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์— ์ค‘๋ณตํ•ด์„œ ์ฝํžˆ์ง€ ์•Š๋„๋ก ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

PR created automatically by Jules for task 405934411580926250 started by @seonghobae

- `target="_blank"` ์™ธ๋ถ€ ๋งํฌ์— ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์šฉ ๊ฒฝ๊ณ  ํ…์ŠคํŠธ(`.sr-only`) ์ถ”๊ฐ€
- ์‹œ๊ฐ์  ์‚ฌ์šฉ์ž๋ฅผ ์œ„ํ•œ `aria-hidden="true"` ์•„์ด์ฝ˜ ์ถ”๊ฐ€
- ๊ธด URL์ด ๋ ˆ์ด์•„์›ƒ์„ ๊นจ์ง€ ์•Š๋„๋ก `.ext-link` ํด๋ž˜์Šค๋ฅผ ํ†ตํ•ด `word-break: break-all` ์ ์šฉ
- `.jules/palette.md`์— ๊ด€๋ จ๋œ UX/์ ‘๊ทผ์„ฑ ํ•™์Šต ๊ธฐ๋ก ์ถ”๊ฐ€
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: Youโ€™ve used the included review currently available.

Learn how review limits work.

Review configuration:

โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c1855636-04e8-4d4a-b987-16055ba9ad24

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 2949d30 and aaa6a14.

๐Ÿ“’ Files selected for processing (2)
  • .jules/palette.md
  • scanner/dashboard/index.html
  • Autopilot ยท Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

Restore the protected develop tree. Canonical Draft PR #1361 preserves the complete user-visible requirement with the safer overflow-wrap boundary and an executable regression; this branch has no independent valid delta.

Copy link
Copy Markdown
Contributor Author

Current-head review disposition (complete successor carryover)

#1361 completely carries the valid external-reference requirements: secure target="_blank" behavior, screen-reader new-tab disclosure, visible aria-hidden cue, and long unspaced URL containment. It is stronger than this duplicate because it uses overflow-wrap:anywhere rather than word-break:break-all and includes an executable regression in tests/test_dashboard_core.py. #1364 preserves the associated baseline/CHANGELOG evidence. The generator-local .jules/palette.md prescription is not product authority and its unconditional word-break:break-all guidance is intentionally not carried.

The ordinary child restores the protected tree without force-push or destructive rebase. Closure is based on verified complete successor carryover; no valid user-visible, test, or governance delta is lost. #1361/#1364 remain Draft pending their documented browser, locale, performance, CodeQL, and independent-approval gates.

@seonghobae seonghobae closed this Oct 1, 2026
@google-labs-jules

Copy link
Copy Markdown

Current-head review disposition (complete successor carryover)

#1361 completely carries the valid external-reference requirements: secure target="_blank" behavior, screen-reader new-tab disclosure, visible aria-hidden cue, and long unspaced URL containment. It is stronger than this duplicate because it uses overflow-wrap:anywhere rather than word-break:break-all and includes an executable regression in tests/test_dashboard_core.py. #1364 preserves the associated baseline/CHANGELOG evidence. The generator-local .jules/palette.md prescription is not product authority and its unconditional word-break:break-all guidance is intentionally not carried.

The ordinary child restores the protected tree without force-push or destructive rebase. Closure is based on verified complete successor carryover; no valid user-visible, test, or governance delta is lost. #1361/#1364 remain Draft pending their documented browser, locale, performance, CodeQL, and independent-approval gates.

Understood. Acknowledging that this work is now obsolete as the valid changes have been carried over to PR #1361 and #1364, and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant