fix(dashboard): announce and mark references that open a new tab - #1201
fix(dashboard): announce and mark references that open a new tab#1201seonghobae wants to merge 10 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jules current head Repair acceptance:
|
Understood. I have reverted the hardcoded Korean suffix to maintain English locale consistency and implemented the WCAG G201 visual+assistive indicator pattern. An external link SVG icon has been added alongside an |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| def test_dashboard_external_links_have_accessible_visual_indicator(): | ||
| """External links opening in new tabs must have both an assistive warning and a visual indicator (WCAG G201).""" | ||
| from html.parser import HTMLParser | ||
| import re |
seonghobae
changed the title
1 participant
Current bounded UI contract
Protected base:
develop@e71d37e7c58118e6764c96ab7c4492fe33eed6f8.Exact current head:
95c25d01c70f32fb644c640d4d27d795ea9b0979.Lifecycle: Draft.
Finding-reference links already open with
target="_blank". This change gives that context switch both a visible external-link indicator and an assistive description referenced by the link. The SVG is hidden from the accessibility tree so it does not duplicate the link name.Fleet repair restored
.jules/palette.mdbyte-for-byte to protected authority via ordinary non-force descendant95c25d01; fresh compare now contains onlyscanner/dashboard/index.htmlandtests/test_dashboard_core.py(ahead 10 / behind 0). The removed doctrine asserted a universal policy from one dashboard implementation; that claim is broader than the checked-in evidence.The Python regression parses the generated link template and verifies
target,rel,aria-describedby, and decorative-SVG attributes. That is useful structural evidence, but it does not prove browser accessibility-tree output or announcement behavior. Do not call the accessibility work complete from static HTML parsing alone.Material UI acceptance
Keep Draft until this unchanged exact head has current browser evidence showing:
No screenshot, AT announcement, or real-browser E2E evidence is claimed yet.
Delivery Gate: intentionality PASS; functional completeness PARTIAL; content fit PASS; resilience PENDING; evidence FAIL/PENDING; product identity PASS.
No force push, destructive rebase, self-approval, gate weakening, scanner suppression, synthetic status, source-neutral retrigger, or predecessor evidence transfer.