Skip to content

a11y(dashboard): retire superseded new-tab announcement lane - #1193

Closed
seonghobae wants to merge 4 commits into
developfrom
palette-external-link-a11y-5550279877693930799
Closed

a11y(dashboard): retire superseded new-tab announcement lane#1193
seonghobae wants to merge 4 commits into
developfrom
palette-external-link-a11y-5550279877693930799

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Fleet disposition

Closed only under the verified-successor exception.

Open Draft #1201 now carries the valid intent more completely at exact head 95c25d01c70f32fb644c640d4d27d795ea9b0979: reference links that already use target="_blank" retain their visible URL identity, gain a visible external-link indicator, and reference one assistive new-tab description while the decorative SVG stays out of the accessibility tree. #1201 also adds structural regression coverage for the link/description/SVG contract. This predecessor's feature-local .jules/palette.md generalization is not authoritative product delta and is not transferred.

The successor is not promoted by this closure. Its hard-coded English assistive description remains incompatible with claiming the fleet's KO/EN/JA/ZH/VI/ES/DE/FR localization acceptance, and static parsing is not real browser/AT evidence. #1201 therefore remains Draft until the product's canonical versioned translation-resource boundary owns that screen key, locale expansion/fallback is verified, and current-head browser accessibility-tree/keyboard/responsive evidence plus hosted gates and independent review are terminally acceptable.

No predecessor checks/reviews are transferred. No force push, destructive rebase, self-approval, gate weakening, scanner suppression, synthetic status, or source-neutral retrigger.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: fd7d8320-c116-418c-b0d2-97679248ea3f

📥 Commits

Reviewing files that changed from the base of the PR and between e71d37e and 86fbdf6.

📒 Files selected for processing (2)
  • .jules/palette.md
  • scanner/dashboard/index.html

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

참조 링크의 target="_blank" 동작을 화면 판독기 사용자에게 알리는 aria-label을 추가했습니다. 동일한 접근성 처리 지침을 학습 문서에 기록했습니다.

Changes

접근성 링크 안내

Layer / File(s) Summary
새 탭 링크 접근성 적용
.jules/palette.md, scanner/dashboard/index.html
참조 링크에 새 탭 열림을 알리는 aria-label을 추가했습니다. target="_blank" 링크에 접근성 안내를 제공하는 방법을 문서화했습니다.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to fbed9

Dashboard reference links that open in a new tab now announce that context change to screen-reader users, with no visual or behavioral change. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 새 탭으로 열리는 참조 링크에 접근성 안내를 추가하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-external-link-a11y-5550279877693930799

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as draft September 8, 2026 19:00
@seonghobae seonghobae changed the title 🎨 Palette: 외부 링크 접근성 개선 fix(a11y): announce new-tab reference links Sep 8, 2026
@seonghobae seonghobae changed the title fix(a11y): announce new-tab reference links a11y(dashboard): retire superseded new-tab announcement lane Sep 10, 2026
@seonghobae seonghobae closed this Sep 10, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Security Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant