Skip to content

fix(console): expose disabled state while scan details load #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seonghobae wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

fix(console): expose disabled state while scan details load #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5aa9f0f
🎨 Palette: Add proper visual and functional guards for aria-busy in c…
seonghobae Sep 9, 2026
dd2e33a
test(console): require semantic disabled state while details load
seonghobae Sep 9, 2026
5cad14b
fix(console): expose disabled state during detail requests
seonghobae Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,7 @@
## 2026-08-12 - Skip to Content Accessibility
**Learning:** Screen reader and keyboard-only users experience significant friction when forced to navigate through repetitive header controls on every page load.
**Action:** Keep a visible-on-focus skip link as the first interactive element, target a programmatically focusable main container, and give the focused link a high-contrast outline.

## 2024-05-19 - console.html pointer-events anti-pattern
**Learning:** Relying solely on CSS `pointer-events: none` to disable interactions is an accessibility anti-pattern because it fails to prevent keyboard interactions (Enter/Space). Always pair visual CSS disabling with semantic state management, such as the `disabled` attribute for native buttons or `aria-disabled="true"`/`aria-busy="true"` combined with JS event guards (`if (el.getAttribute('aria-busy') === 'true') return;`) for non-native elements.
**Action:** Implemented JS event guards in click and keydown listeners alongside CSS `pointer-events: none` and `opacity: 0.6` for loading states on `tr.scan` rows.
8 changes: 6 additions & 2 deletions scanner/dashboard/console.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
.err{color:var(--crit);font-weight:600}
code{background:var(--bg);padding:1px 5px;border-radius:4px}
.hidden{display:none}
tr.scan[aria-disabled="true"]{pointer-events:none;opacity:0.6;cursor:default}
</style>
</head>
<body>
Expand Down Expand Up @@ -88,6 +89,7 @@ <h1>AppGuardrail Console</h1>
detail.innerHTML="";
if(lastDetailFocus instanceof HTMLElement && lastDetailFocus.isConnected){
lastDetailFocus.removeAttribute("aria-busy");
lastDetailFocus.removeAttribute("aria-disabled");
delete lastDetailFocus.dataset.detailRequest;
lastDetailFocus.focus();
}
Expand Down Expand Up @@ -135,8 +137,8 @@ <h1>AppGuardrail Console</h1>
<td>${esc(s.created_at)}</td><td>${esc(s.repo||"—")}</td><td><code>${esc((s.commit||"—").slice(0,10))}</code></td>
<td>${s.total}</td><td>${pill(s.deploy_blocking,"var(--crit)")}</td><td>${pill(s.new_blocking,"var(--high)")}</td></tr>`).join("")||'<tr><td colspan="6" class="muted">No scans. POST to /api/v1/scans from CI.</td></tr>';
document.querySelectorAll("tr.scan").forEach(tr=>{
tr.onclick=()=>detail(tr.dataset.id,tr);
tr.addEventListener('keydown', e => { if(e.key === 'Enter' || e.key === ' ') { e.preventDefault(); detail(tr.dataset.id,tr); } });
tr.onclick=()=>{if(tr.getAttribute("aria-disabled")==="true")return;detail(tr.dataset.id,tr);};
tr.addEventListener('keydown', e => { if(e.key === 'Enter' || e.key === ' ') { e.preventDefault(); if(tr.getAttribute("aria-disabled")==="true")return; detail(tr.dataset.id,tr); } });
});
}catch(e){ $("#msg").classList.remove("hidden");$("#app").classList.add("hidden");
$("#msg").innerHTML=`<span class="err">${esc(e.message)}</span>`; }
Expand All @@ -149,6 +151,7 @@ <h1>AppGuardrail Console</h1>
if(tr){
tr.dataset.detailRequest=String(requestId);
tr.setAttribute("aria-busy","true");
tr.setAttribute("aria-disabled","true");
}
d.classList.remove("hidden");
d.innerHTML='<div aria-live="polite" class="muted">Loading scan details...</div>';
Expand All @@ -173,6 +176,7 @@ <h1>AppGuardrail Console</h1>
}finally{
if(tr&&tr.dataset.detailRequest===String(requestId)){
tr.removeAttribute("aria-busy");
tr.removeAttribute("aria-disabled");
delete tr.dataset.detailRequest;
}
}
Expand Down
3 changes: 3 additions & 0 deletions tests/test_console_detail_loading_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,12 @@ def test_console_exposes_loading_busy_and_error_states():
html = _console_html()

assert 'tr.setAttribute("aria-busy","true");' in html
assert 'tr.setAttribute("aria-disabled","true");' in html
assert 'aria-live="polite" class="muted">Loading scan details...' in html
assert 'role="alert" class="err">Error loading details:' in html
assert 'tr.removeAttribute("aria-busy");' in html
assert 'tr.removeAttribute("aria-disabled");' in html
assert 'lastDetailFocus.removeAttribute("aria-disabled");' in html


def test_console_detail_scrolling_respects_reduced_motion():
Expand Down
Loading