fix(console): expose disabled state while scan details load - #1198
fix(console): expose disabled state while scan details load#1198seonghobae wants to merge 3 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reachedNext included review available in 16 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact-head verification update for Standards basis: WAI-ARIA 1.2 defines Material-UI Delivery Gate at this head: intentionality PASS; functional completeness PARTIAL (source contract + exact-head Tests GREEN, browser activation matrix pending); content appropriateness PASS; resilience PARTIAL (keyboard guards present, live browser/focus/error evidence pending); evidence FAIL/PENDING for current-head screenshot/AX-tree/E2E; distinctiveness N/A. Do not mark Ready until the remaining exact-head checks and real-browser pointer/Enter/Space/focus/success/error evidence are terminal. |
Scan rows use
role="button"and suppress pointer/Enter/Space activation while a detail request is in flight.aria-busyalone describes an element being updated; it does not communicate that the button-like row is temporarily inoperable. WAI-ARIA 1.2 definesaria-disabledfor a perceivable but non-operable element and expects the disabled presentation to match the state.This branch now keeps both states distinct:
aria-busy="true"communicates the pending update, whilearia-disabled="true"is the activation contract used by pointer/keyboard guards and the disabled visual state. Both attributes are removed on completion and on explicit close/focus restoration.TDD lineage:
dd2e33aa254bab840cf4b6223989a9fced7e866erequiresaria-disabledset/cleanup alongside the existing busy-state contract. Hosted Tests for that generation were still queued when the production descendant landed, so it is not claimed as hosted RED.5cad14bf125bbf3af0df29dded4b087c2aa90c07implements the minimal semantic state and cleanup without changing request ordering or detail rendering.Remaining acceptance before Ready: exact-head Tests/Security/SAST/CodeQL plus real-browser pointer, Enter, Space, focus restoration, success/error/cancel behavior and accessibility-tree evidence at current head. No screenshot/E2E evidence is claimed yet.