ui(dashboard): retire duplicate file-picker proxy predecessor - #1181
seonghobae wants to merge 9 commits into
Conversation
- 기본 `<input type="file">`을 시각적으로 숨기고 일관된 스타일의 프록시 `<button>`으로 대체 - 'label-in-name' 원칙에 따라 중복된 `aria-label` 제거 - `.jules/palette.md`에 프록시 버튼 접근성 네이밍 패턴 학습 기록 추가 - UI 계약 테스트 업데이트 (`tests/test_dashboard_core.py`)
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added
enhancement
ChatGPT Codex Connector
- 기본 `<input type="file">`을 시각적으로 숨기고 일관된 스타일의 프록시 `<button>`으로 대체 - 'label-in-name' 원칙에 따라 중복된 `aria-label` 제거 - `.jules/palette.md`에 프록시 버튼 접근성 네이밍 패턴 학습 기록 추가 - UI 계약 테스트 업데이트 (`tests/test_dashboard_core.py`)
- 기본 `<input type="file">`을 시각적으로 숨기고 일관된 스타일의 프록시 `<button>`으로 대체 - 'label-in-name' 원칙에 따라 중복된 `aria-label` 제거 - `.jules/palette.md`에 프록시 버튼 접근성 네이밍 패턴 학습 기록 추가 - UI 계약 테스트 업데이트 (`tests/test_dashboard_core.py`)
- 기본 `<input type="file">`을 시각적으로 숨기고 일관된 스타일의 프록시 `<button>`으로 대체 - 'label-in-name' 원칙에 따라 중복된 `aria-label` 제거 - `.jules/palette.md`에 프록시 버튼 접근성 네이밍 패턴 학습 기록 추가 - UI 계약 테스트 업데이트 (`tests/test_dashboard_core.py`)
- 기본 `<input type="file">`을 시각적으로 숨기고 일관된 스타일의 프록시 `<button>`으로 대체 - 'label-in-name' 원칙에 따라 중복된 `aria-label` 제거 - `.jules/palette.md`에 프록시 버튼 접근성 네이밍 패턴 학습 기록 추가 - UI 계약 테스트 업데이트 (`tests/test_dashboard_core.py`)
- 기본 `<input type="file">`을 시각적으로 숨기고 일관된 스타일의 프록시 `<button>`으로 대체 - 'label-in-name' 원칙에 따라 중복된 `aria-label` 제거 - `.jules/palette.md`에 프록시 버튼 접근성 네이밍 패턴 학습 기록 추가 - UI 계약 테스트 업데이트 (`tests/test_dashboard_core.py`)
seonghobae
changed the title
1 participant
Fleet disposition
Closed only under the verified-successor exception.
This branch already identified #1131 as the canonical successor. Fresh review confirms that #1131 exact head
5f938580fd32b15fc99508b26cbc47839f577a04retains every valid delta here: the visible nativeUpload findings filebutton, hidden file input, explicit picker delegation, the existing same-file value-reset flow, and the dashboard-core markup regression. This branch's generated.jules/palette.mddoctrine had already been restored to protected authority at exact head6435d9c52a936e8bb30ebebefceafc20304410d4, so there is no additional doctrine/evidence contract to preserve.#1131 remains Draft and explicitly owns the missing material-UI acceptance: actual browser pointer/Enter/Space picker activation, cancel/reselect, focus, accessibility-tree naming, responsive/error-state behavior, current-head screenshots/E2E, hosted gates and qualifying independent review. Closing this duplicate does not promote or merge the successor and does not transfer predecessor checks.
No force push, destructive rebase, self-approval, gate weakening, scanner suppression, synthetic status, or source-neutral retrigger.