feat(scanner): reject plugin checksum files without a sibling signature - #1175
Draft
seonghobae wants to merge 13 commits into
Draft
feat(scanner): reject plugin checksum files without a sibling signature#1175seonghobae wants to merge 13 commits into
seonghobae wants to merge 13 commits into
Conversation
Lock first-party checksum digest rows without a sibling Cosign or GPG signature file. Keep missing checksums, comment-only files, and non-empty .sig/.asc/cosign.bundle on their existing classes. Relates to #1099.
Fail closed when a first-party checksum lists digests but has no non-empty sibling .sig, .asc, .gpg, .bundle, or cosign.bundle as claude-plugin-unsigned-checksum. Network Cosign/GPG verify is not performed. Mismatch stays its own class. Relates to #1099.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added a commit
that referenced
this pull request
Sep 8, 2026
Summary: - Snapshot 2026-09-08 03:09 UTC records Draft #1175 `eb2389e` stacked on #1174. - Checksum digest rows without a sibling signature fail closed. - Remaining leftover: deep directory recursion. Rationale: - #999 is the single writer of the product-technical gap baseline. - Do not Close #1099, #1174, or #1169. Tests: - documentation-only; detector evidence lives on #1175 (416 passed)
This was referenced Sep 8, 2026
seonghobae
added a commit
that referenced
this pull request
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor of #1174 / issue #1099. Does not Close those. Checksum mismatch stays #1169. Hosted deploy stays #1174. Pass is not Noema admission.
Unique delta
Fail closed when a first-party checksum file lists digest rows but has no sibling signature artifact (
claude-plugin-unsigned-checksum, CWE-347):SHA256SUMS/*.sha256without.sig,.asc,.gpg,.bundle, orcosign.bundlefails admission.sigor a symlink.sigis not a signatureclaude-plugin-checksum-mismatchand can fire with this class#1169 remains owner of digest disagreement.
Evidence
RED
5a7abb3then GREENeb2389etests/test_claude_plugin_unsigned_checksum.pyplus sibling mismatch lockpredecessor checksum plugin coverage suite 416 passed on Python 3.13
no hosted workflow is created on this stacked custom base; keep Draft until stacked integration evidence is available
Normal two-parent descendant
aa5128fb115668ce8abf869dd1d711e72fe09baaintegrates feat(scanner): fail closed on plugin terraform apply and helm install #1173 command-context RED/GREEN without force-push; compare to current parentd8f5f76400f9...is 4 ahead / 0 behind and preserves this PR's unique delta.Candidate source AST passes; the final stacked detector preserves 3/3 negative command-context and 2/2 later-real-command probes. Custom-base hosted workflow evidence remains absent, so Draft stays required.
Relates to #1099. Relates to #1174.
Current quoted-command context repair
This descendant inherits #1173 RED
d7384e53d44a426356a73e24b2b9cc3fe153de27and final canonical repair3a5b14771cc7abb6553fa1ec9bcd8b62acc947acwithout copying a leaf workaround. Exact head:77f7ffa03cc97670ae66e329b6b811e6264867a4; current parent:2967d093985f96dd0830cd600b86f7f07c7235df; Git compare is 0 behind and preserves this PR's unique detector/test delta. The top #1183 source AST and extracted helper probes pass quoted/reporting negatives while preserving direct and command-substitution positives. This custom-base PR stays Draft until its own hosted integration and independent review are terminal.Current assignment-value context repair — 2026-09-08
This normal two-parent descendant inherits canonical #1173 RED
90ae232e852b3d01463d978f9bccd9157c341fe7and GREEN1e6a3eb43a5bc2d146656af13e7fa6cad2a77315without a leaf workaround. Exact head:29011cca6f465dbd988465c6ff67fe7caa18223b; current parent:8b1965da8972a627d40fb7b1866b6828007a4a13; Git compare is 0 behind and preserves this PR's unique detector/test delta. Assignment-value negatives and environment-prefix/direct/substitution positives are present in the exact tree. This custom-base PR remains Draft until its own hosted integration and independent current-head review are terminal. Earlier head strings in this body are historical evidence only.Current heredoc-safe restack — 2026-09-08
Canonical #1173 exact head
184b4b4f55906284ac1d8059e46cec8f0d9cfc9afixes closed literal here-document payload false positives with RED6f6be77d...→ GREEN12faf2f.... This branch was integrated non-destructively on parentc069e93ed7ca0b82fd19179a6b68f671c3d0be20; exact head isbb9cd1dd6af007f2b1e85978974150480da3fad6. GitHub compare reportsbehind_by=0,ahead_by=13; the PR's unique detector delta remains in the tree. Exact-head hosted integration and independent review are not terminal, so this PR remains Draft. Earlier head strings are historical evidence only.