Skip to content

feat(scanner): reject hidden undeclared plugin executables - #1146

Draft
seonghobae wants to merge 3 commits into
feat/claude-plugin-dynamic-eval-1099from
feat/claude-plugin-hidden-executable-1099
Draft

seonghobae wants to merge 3 commits into
feat/claude-plugin-dynamic-eval-1099from
feat/claude-plugin-hidden-executable-1099

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Current repair boundary — 2026-09-12

Successor of #1145 / issue #1099. Does not Close those. Does not steal G-06 #1133 or #1145 eval unique delta. .git metadata is not a plugin executable surface.

Unique delta

Fail closed on hidden undeclared executable or config surfaces (claude-plugin-hidden-undeclared-executable):

  • .bin/run.sh and .hooks/secret.py not declared in plugin.json fail admission
  • hidden config such as .config.json and extensionless .bin/tool fail admission
  • declared hooks/pre.sh is not this finding (may still be inventory)
  • .gitignore only is not this finding
  • .mcp.json stays the MCP class
  • non-hidden scripts/hidden.py stays claude-plugin-undeclared-executable
  • snippets omit secrets and raw bidi

#1145 remains owner of dynamic eval/exec on hook surfaces.

Test plan

  • RED then GREEN (tests/test_claude_plugin_hidden_executable.py)
  • Detector statement coverage 1428/1428 with plugin suites
  • Exact-head Checks on this head
  • Keep Draft until current-head gates are GREEN

Relates to #1099. Relates to #1145.

RED: hidden .bin/.hooks surfaces must fail closed; .git and
.gitignore stay negative. Relates to #1099.
Fail closed on hidden executable or config surfaces that are not
declared in plugin.json. .git metadata is not a plugin surface.
Relates to #1099.
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

seonghobae added a commit that referenced this pull request Sep 7, 2026
Summary:
- Snapshot 14:09 UTC records Draft #1146 `94946c7` stacked on #1145.
- Hidden undeclared executable/config surfaces fail closed.
- `.git/` and `.gitignore` stay outside that class.

Rationale:
- #999 is the single writer of the product-technical gap baseline.
- #1099 remaining surfaces stay on stacked successors, not Close.

Tests:
- documentation-only; detector evidence lives on #1146 (1428/1428)
seonghobae added a commit that referenced this pull request Sep 7, 2026
Refresh the single-writer gap baseline from live exact-head evidence:
Draft #1150 on #1146, concurrent #1148 sentinel, and G-06 #1133
exact-head coverage SUCCESS. Relates to #1099.
@seonghobae seonghobae added enhancement New feature or request priority: medium Normal-priority or P2 work labels Sep 8, 2026 — with ChatGPT Codex Connector

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant