fix(network): restore bounded WebSocket frame transport - #243
Draft
seonghobae wants to merge 19 commits into
Draft
fix(network): restore bounded WebSocket frame transport#243seonghobae wants to merge 19 commits into
seonghobae wants to merge 19 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Integrate exact parent 55fef0c without rewriting either branch. Full verification found a separate premature peer-close fixture at the same owner; publishing waits for that repair and fresh gates. Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
This was referenced Sep 5, 2026
Preserve the frame-transport delta while adopting exact owner 2d0e9f6. Retain both parent and descendant RCA documentation; full local Rust gates and exact production coverage pass on the integrated tree. Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
This was referenced Sep 5, 2026
…ng-mask-20260909 fix(network): source WebSocket masks from OS CSPRNG
…shake-csprng-20260909 fix(network): source WebSocket client keys from OS CSPRNG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current dependency and scope
Draft frame-transport repair at exact head
97fab641ed9d76e6c515eadcef0629edfc8064a3, based on opening-response owner #2422d0e9f69df9ade21d8e8e3d807c3ff644d83b310. Two ordinary parent merges preserve existing history and the bounded frame-transport delta. No force push or destructive restack occurred.The retained implementation provides masked UTF-8 text/Pong writes, adjacent masking-key reuse rejection, bounded unmasked server-frame reads, strict frame lengths/opcodes/control/Close validation, and typed fail-closed I/O/cleanup errors on the already verified transport. It neither reconnects nor grants browser, policy, secret or Agent authority.
Root-cause repair and integration
The descendant #255 complete Rust run exposed an invalid-deadline fixture that was already fixed at #242 but missing below the stale #243 edge. Adopting that parent exposed a second premature-close race in the mismatched-accept fixture. Owner #242 fixed the remaining exchange fixture paths with one shared test-only server that reads the full request and retains its stream through client assertions.
This PR adopts those canonical owner repairs. The fixture file is byte-identical to current #242; the unique parent-relative delta remains frame transport, public exports, masking regressions, integration doctoring and changelog. Production cleanup errors and security gates are unchanged.
Exact-head GREEN — 2026-09-08
Native CI
33952588687is terminal success on unchanged exact97fab641ed9d76e6c515eadcef0629edfc8064a3. Production coverage job101270020891passed measurement, diagnostics upload and exact production coverage enforcement. Rust contracts job101270020934passed Python repository contracts, canonical formatting, workspace check, full tests, strict Clippy and warnings-denied API documentation. The prior queued description is stale and is superseded by this exact-head evidence.The earlier exact-tree local verification remains supporting evidence only: 139 Python contracts, Rust 1.97.1 fmt/check/tests/Clippy/rustdoc, and pinned-nightly production coverage at 884/884 functions, 8733/8733 lines, 11176/11176 regions and 1008/1008 branches. Hosted exact-head GREEN is now the controlling repository-quality evidence.
Remaining gates
Keep Draft while prerequisite #242 remains Draft. #242 itself still records an exercised dependency-root workflow-generation RED on repaired #195, owned by #279; this #243 GREEN must not bypass that prerequisite. Later descendants must retain parent-first adoption and regenerate their own exact-head evidence after foundation movement.
No counted approval, protected-main integration, browser-runtime acceptance, release, force update, destructive rebase, workflow/ruleset/secret mutation or self-approval is claimed.