fix(network): source WebSocket masks from OS CSPRNG - #303
Merged
seonghobae merged 1 commit intoSep 9, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 9, 2026
seonghobae
merged commit Sep 9, 2026
f15b4ae
into
repair/webdriver-bidi-frame-transport-restack
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Traceability
97fab641ed9d76e6c515eadcef0629edfc8064a3.docs/doctoring.md; updatesAGENTS.md,CLAUDE.md, andCHANGELOG.md.Test-first evidence
cargo test -p originweave-network --test webdriver_bidi_websocket_masking_key_reuse established_stream_uses_os_random_masks_for_text_and_pong --lockedfailed before the random-mask write API existed.cargo test -p originweave-network --locked(67 tests);cargo clippy -p originweave-network --all-targets --all-features -- -D warnings;RUSTDOCFLAGS='-D warnings' cargo doc -p originweave-network --no-deps --locked.cargo +nightly-2026-08-01 llvm-cov --locked --workspace --all-features --branch --json --summary-only --output-path coverage-final-three.json && python3 scripts/ci/verify_coverage.py coverage-final-three.jsonreported functions, lines, regions, and branches at 100%.No release, deployment, browser integration, or merge is claimed.