Skip to content

feat(core): apply reviewed Position lifecycle changes - #112

Draft
seonghobae wants to merge 23 commits into
feat/position-lifecycle-reviewfrom
feat/position-lifecycle-application
Draft

feat(core): apply reviewed Position lifecycle changes#112
seonghobae wants to merge 23 commits into
feat/position-lifecycle-reviewfrom
feat/position-lifecycle-application

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Current authority — 2026-09-06

Child exact head: 1889851f9f8c7e0528e047ec53f33f947be6dd88.
Recorded stack base remains predecessor #111 snapshot b9e85a1b8eb92f168fd261aa150a6204490c8023.

Parent #111 is now exact 25aaef404fc60cdeb1be5a5575cd80491c61ebb2, based directly on protected develop@eb9757f8649aaad026a9865508d9aad50c1a7a4f, open · Draft · mechanically mergeable. #111's protected-parent reconciliation keeps the retired Position Lifecycle Review leaf workflow deleted, preserves the package's exact installed-wheel/100%-coverage contract under canonical Foundation, and corrects stale repository-governance documentation. Its fresh successor gates are non-terminal, so no parent evidence transfers to this child.

Buyer-visible gap

#111 governs human review of Position lifecycle changes but intentionally does not mutate authoritative Position truth. This dependency-first slice adds the authoritative bitemporal application boundary: an approved review is revalidated against fresh locked Position/Assignment truth, then and only then may a correction-preserving PositionVersion plus immutable audit/outbox evidence be written.

The existing child delta includes immutable position_lifecycle_application_record, exact v1 canonical review JSON/SHA-256 validation, requester/reviewer/applier separation, controlled transitions/reasons, PostgreSQL-owned system time, fresh Position/Assignment snapshot recomputation, staffing safety, predecessor interval closure plus successor PositionVersion insertion, audit/outbox correlation, append-only history and FORCE-RLS evidence. Historical exact child run 33184240552 on 1889851f... is predecessor-stack evidence only; it cannot prove compatibility with the current parent/protected tree.

Stack discipline

Keep Draft and do not copy mutable #111 bytes into this child. Required order is:

#111 exact-head acceptance → normal protected integration → non-force #112 adoption/retarget to fresh protected develop → reconcile migration/document/inventory/workflow ordering while preserving the complete application delta → regenerate any final deterministic provenance → rerun every applicable Foundation/PostgreSQL/SAST/Security/central-review gate on the resulting child head.

Current effective ruleset 18156473 requires one approving review, stale-review dismissal, review-thread resolution, extra approval for unattributed changes, seven central required workflows, and deletion/non-fast-forward protection; last-push approval is currently false. Issue #89 owns the remaining central governance/control-plane gap, including routine administrator bypass. Do not self-approve, use routine bypass, force-push/destructively rebase, transfer parent/predecessor checks or reviews, restore retired leaf CI, weaken gates, or Close this valid dependent delta.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 25, 2026 23:30

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 4 potential issues.

Open in Devin Review

Comment thread database/migrations/0023_position_lifecycle_application.sql Outdated
Comment thread database/migrations/0023_position_lifecycle_application.sql
Comment thread database/migrations/0025_position_lifecycle_snapshot_hardening.sql
Comment thread tests/test_position_lifecycle_transition_validation_postgres.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant