Skip to content

feat(ui): add Position lifecycle review states - #135

Draft
seonghobae wants to merge 9 commits into
feat/hr-workspace-protected-read-statefrom
feat/hr-workspace-position-lifecycle-review-state
Draft

feat(ui): add Position lifecycle review states#135
seonghobae wants to merge 9 commits into
feat/hr-workspace-protected-read-statefrom
feat/hr-workspace-position-lifecycle-review-state

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Buyer-visible gap

The active HR Workspace stack has shared protected-read accessibility semantics (#130), while Position lifecycle governance (#111) and authoritative application (#112) are separate backend owner lanes. There was no workflow-specific interaction proof showing a reviewer that a Position freeze/close/abolish/reactivate proposal is a high-impact human review, not an immediate mutation.

This dependency-first child adds that missing UI/Storybook contract only. It consumes the existing Figma Orgmetra Baseline Storybook Inventory node 1:64, whose live design context requires default / hover / focus / disabled / loading / validation-error / read-only / high-risk-confirmation states. It does not duplicate #111 review evidence, #112 authoritative application, or any foreign service contract.

Test-first sequence

Contract head 0542d702d7696ce3b2128f984ee86c81c7fba576 added the focused exact-coverage workflow and regression before the production module, Storybook stories, CSS, traceability, and doctoring artifacts existed. No hosted run materialized on that short-lived head, so it is not claimed as terminal RED evidence.

The subsequent implementation added:

  • explicit high-risk-confirmation before review recording;
  • loading/recording duplicate-action prevention;
  • recorded review as read-only evidence that explicitly does not apply lifecycle mutation;
  • fail-closed denied, stale, staffing-blocked, and error states with concrete next actions;
  • constant, value-minimized UI evidence with no Person/candidate identifiers, compensation/rating/assessment values, credentials/tokens, prompt/model output;
  • Storybook/Figma correlation to node 1:64, existing Orgmetra design tokens, visible focus, and a 44px action target;
  • traceability that keeps feat(core): govern Position lifecycle-change review #111 governance and feat(core): apply reviewed Position lifecycle changes #112 application separate and requires fresh authoritative Position/Assignment truth before any consequential mutation; and
  • WAI-ARIA 1.2 / WCAG 2.2 primary accessibility references under docs/doctoring.

Exact-current-head evidence

Base/parent: #130 feat/hr-workspace-protected-read-state@b3b30058a79174000919d566fbbb1fdad80c62bf.
Exact child head: c06c0a2ab90a6cbd95c8c48f6cb00558e91b9684.
GitHub reports open · Draft · mergeable.

Position lifecycle review state contract run 33214485986, job 98994955163, is terminal GREEN on exact child head c06c0a2ab90a6cbd95c8c48f6cb00558e91b9684; it passed the focused interaction contract with exact 100% line/branch/function coverage and a clean checkout.

Fresh submitted reviews and review threads are empty. This is focused stack-local evidence only; parent checks/reviews never transfer and the child does not claim default-branch integration.

Dependency / merge governance

Keep Draft and process #130 first. After #130 actually integrates, retarget/revalidate this child against fresh develop, reconcile any parent/UI changes, then rerun every applicable browser/accessibility/Foundation/Recovery/SAST/Security and central required workflow on one resulting exact head.

The UI confirmation remains human-review evidence only. Any authoritative Position lifecycle change must separately re-resolve fresh same-tenant bitemporal Position/Assignment truth, staffing safety, accountable actor authority/separation, business/system time, and immutable audit/outbox evidence through the #111/#112 owner boundaries.

Do not self-approve, use routine administrator bypass, race another lifecycle writer, transfer predecessor evidence, treat UI confirmation as mutation authority, or mutate another dedicated-writer repository.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant