feat(ui): add Position lifecycle review states - #135
Draft
seonghobae wants to merge 9 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer-visible gap
The active HR Workspace stack has shared protected-read accessibility semantics (#130), while Position lifecycle governance (#111) and authoritative application (#112) are separate backend owner lanes. There was no workflow-specific interaction proof showing a reviewer that a Position freeze/close/abolish/reactivate proposal is a high-impact human review, not an immediate mutation.
This dependency-first child adds that missing UI/Storybook contract only. It consumes the existing Figma
Orgmetra BaselineStorybook Inventory node1:64, whose live design context requiresdefault / hover / focus / disabled / loading / validation-error / read-only / high-risk-confirmationstates. It does not duplicate #111 review evidence, #112 authoritative application, or any foreign service contract.Test-first sequence
Contract head
0542d702d7696ce3b2128f984ee86c81c7fba576added the focused exact-coverage workflow and regression before the production module, Storybook stories, CSS, traceability, and doctoring artifacts existed. No hosted run materialized on that short-lived head, so it is not claimed as terminal RED evidence.The subsequent implementation added:
high-risk-confirmationbefore review recording;1:64, existing Orgmetra design tokens, visible focus, and a 44px action target;docs/doctoring.Exact-current-head evidence
Base/parent: #130
feat/hr-workspace-protected-read-state@b3b30058a79174000919d566fbbb1fdad80c62bf.Exact child head:
c06c0a2ab90a6cbd95c8c48f6cb00558e91b9684.GitHub reports open · Draft · mergeable.
Position lifecycle review state contractrun33214485986, job98994955163, is terminal GREEN on exact child headc06c0a2ab90a6cbd95c8c48f6cb00558e91b9684; it passed the focused interaction contract with exact 100% line/branch/function coverage and a clean checkout.Fresh submitted reviews and review threads are empty. This is focused stack-local evidence only; parent checks/reviews never transfer and the child does not claim default-branch integration.
Dependency / merge governance
Keep Draft and process #130 first. After #130 actually integrates, retarget/revalidate this child against fresh
develop, reconcile any parent/UI changes, then rerun every applicable browser/accessibility/Foundation/Recovery/SAST/Security and central required workflow on one resulting exact head.The UI confirmation remains human-review evidence only. Any authoritative Position lifecycle change must separately re-resolve fresh same-tenant bitemporal Position/Assignment truth, staffing safety, accountable actor authority/separation, business/system time, and immutable audit/outbox evidence through the #111/#112 owner boundaries.
Do not self-approve, use routine administrator bypass, race another lifecycle writer, transfer predecessor evidence, treat UI confirmation as mutation authority, or mutate another dedicated-writer repository.