refactor(operators): use semantic backfill, estimator, catalog, and content identifiers - #966
refactor(operators): use semantic backfill, estimator, catalog, and content identifiers#966seonghobae wants to merge 28 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review finding: the semantic-identifier refactor itself is bounded and I do not see a behavioral/DDD regression in the reviewed diff, but the verification text is now factually stale at the canonical dependency boundary. LineageWeave still pins fast-mlsirm to d025b7d237d8db7ca97a5611606c6285d5870895, while the owner has an immutable v0.9.1 release targeting 09f762ded35786dd1078222a4577ff09d649816f; the current pin predates that release. I opened #967 as the dedicated consumer cutover path. Keep this PR narrow: do not copy fast-mlsirm source, add a fallback kernel, weaken the full backend gate, or fold the dependency bump into this naming-only delta. The PR should describe the full-suite limitation as the current stale consumer pin/toolchain boundary and reference #967 rather than calling fast-mlsirm unreleased.
|
Current-head repair note ( |
|
Exact-head repair note ( |
|
Exact-head repair note ( |
Problem
Seven bounded operator commands on protected
main@83eba56149eb802cd63642c507c324c9976ec78eused generic organization-owned identifiers that obscured database, record, result, sampling, estimation-run, batch, catalog-payload, post-content, and configuration responsibilities:No other open PR owned these naming paths.
Completed test-first repairs
577ebda05f8995cc3289c7305d0116f5b65014e2f0825c7cd5655bcee57e5c48b49bcc2ae1520b9cc098fe623c96d264c9b2a5f79bc96765ea73cc62cdeaf039551899c77e68e28b6ef79e74ffee4f804acd000164597b3ddfdecf2d69fc088df17955e356e5d3a21524411b20cb6028b1a4cecc2e423c266982746bd1be37b2599b9fbba92dcffef566dd30,8f03f6d4b082562807e2a67d26d92527f1f9bdb278e8d85b7c93f001d3b7ab74a954f2d168b2913c52443f8fdce26054c9c3783adfcff933e342bf0b7cefc9690b6515c63cc7a86af9263bb09d3f8373Representative names include
_run_post_keyman_backfill,_run_thread_group_key_backfill,_run_channel_weight_estimation,_submit_batch_estimation,_collect_batch_estimation,synchronize_occupational_construct_catalog,database_connection,catalog_payload,runtime_settings,source_post_rows,candidate_window,estimation_run_record,pair_judgment_records, andchannel_weight_estimate. The queue slice adds_queue_backfill_parser,valkey_client,source_post_records,post_content_job_request, andbackfill_summary. The synchronous content slice adds_post_content_backfill_parser,selected_post_records,source_post_record,normalized_post_content,described_image_count, and semantic SQL aliases.Compatibility
Regression contracts preserve existing CLI flags, aggregate JSON result keys, provider request/response fields, pair-sampling geometry, weight fitting, fixed O*NET URL/release/output fields, source-digest validation, SQL selection behavior, PostgreSQL schema, transaction rollback, bounded selection, timeout, incomplete-judgment behavior, persistence, resource close, event publication, and persisted provenance. No HTTP or public product API changes and no database migration.
Verification
90 passedacross naming, normalization, persistence, queue, worker, and static-SQL coverage91 passed, 2 skippedgit diff --checkpassedmainstill pins the olderfast-mlsirm@d025b7d237d8db7ca97a5611606c6285d5870895; the dedicated consumer cutover is now PR deps(fast-mlsirm): consume immutable v0.9.1 owner release target #970 at exact head50807d1e7484fd0aa65bdbf6af015bbe8d739d80, where repository-local Tests/Ontology/PROV-O/SAST are GREEN against the immutable ownerv0.9.1target. deps(fast-mlsirm): consume immutable v0.9.1 owner release target #970 remains unmerged because central Security/CodeQL terminal evidence and qualifying independent approval are still missing. This naming PR therefore does not copy owner source, add a fallback kernel, weaken the backend gate, or absorb that dependency bump before the canonical consumer path lands.Current exact head:
7cefc9690b6515c63cc7a86af9263bb09d3f8373. Proposed until fresh exact-head checks and independent review complete.