docs(gaps): refresh protected delivery evidence - #901
Conversation
Signed-off-by: Codex <codex@localhost>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
Merge the current #780 root after it incorporated protected main@3f61c824. The parent movement only adds docs/index.md; this PR's product-gap baseline delta remains unchanged.
Signed-off-by: Codex <codex@localhost>
seonghobae
left a comment
There was a problem hiding this comment.
Parent #780 moved to 1d8fa267b059289e77301a09985dfac70a439814 to adopt protected #931. This child was immediately reconstructed from that exact parent tree plus its prior baseline blob 42306548ea99983716098c141c61c0d3ee99da74, producing 9e582e4be080ae74bffac83817e639993ac85a71 without force rewrite. The one-file documentation delta is preserved. The independent ADR 0134 / shared StatusNotice semantic defect remains valid and is not resolved by ancestry convergence.
seonghobae
left a comment
There was a problem hiding this comment.
Valid semantic documentation finding: the ADR 0134 row in docs/product-technical-gap-baseline.md still says there is “no shared token-backed exception component,” while protected product history already contains shared StatusNotice (ADR 0220 / delivered #643) and AGENTS explicitly describes StatusNotice as shared success/unavailable/retry copy. This is stale buyer-gap classification, not historical evidence that should be preserved as current truth. Add an executable documentation RED that rejects the obsolete claim, then update only the ADR 0134 row; keep the dated historical overlays untouched.
Summary
This remains a documentation-only child of #780. It preserves the buyer-facing gap-baseline delta without promoting predecessor checks or old protected-head snapshots to current truth.
Live authority
#780@1d8fa267b059289e77301a09985dfac70a439814308ebdfae50606127316fa8c51d772ea93327f64docs/product-technical-gap-baseline.md;tests/test_gap_baseline_status_notice_contract.pyis the focused executable contractADR 0134 repair
Review
5118146683verified that the ADR 0134 matrix row was stale: it said there was no shared token-backed exception component even though protected product history already delivers sharedStatusNoticeunder ADR 0220 / #643. The focused RED requires the matrix to acknowledgeStatusNoticeand rejects that obsolete claim.The causal edit changes one matrix row: protected product already delivers
StatusNotice; the remaining gap is complete Storybook/browser/a11y evidence for success, unavailable, retry, and permission states. It reuses the existing component rather than creating a second exception authority. Historical overlays remain history and are not rewritten.Verified repair and promotion
The first isolated run
34003486164reached the product repair and passed the focused contract plus one-addition/one-deletion causal-diff checks, then failed only because its self-removing harness counted its own workflow deletion. That harness defect was repaired non-force.Follow-up run
34007470247completed GREEN and produced clean staging commitf12243c6b5513a5cb8b3cb43d2ba569da2f59697, tree2d8f1ec5a06736b6875b115dc3e6114409a98b9a. With the product branch still at exact predecessord44cd875a93cb929b6e30b744976d2c19e67d981, only that clean tree was recreated as product commit308ebdfae50606127316fa8c51d772ea93327f64and the branch was fast-forwarded without force. Temporary workflow history was not promoted.The PR remains Draft. The new product-head
Testsrun34009950635is skipped by Draft lifecycle policy, so isolated GREEN is not relabeled as required exact-product-head GREEN and no independent approval is implied.