Skip to content

docs(gaps): refresh protected delivery evidence - #901

Draft
seonghobae wants to merge 14 commits into
fix/voice-export-authority-20260828from
docs/gap-baseline-current-20260901
Draft

docs(gaps): refresh protected delivery evidence#901
seonghobae wants to merge 14 commits into
fix/voice-export-authority-20260828from
docs/gap-baseline-current-20260901

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

This remains a documentation-only child of #780. It preserves the buyer-facing gap-baseline delta without promoting predecessor checks or old protected-head snapshots to current truth.

Live authority

  • parent/base: #780@1d8fa267b059289e77301a09985dfac70a439814
  • current product head: 308ebdfae50606127316fa8c51d772ea93327f64
  • open / Draft
  • product delta remains docs/product-technical-gap-baseline.md; tests/test_gap_baseline_status_notice_contract.py is the focused executable contract

ADR 0134 repair

Review 5118146683 verified that the ADR 0134 matrix row was stale: it said there was no shared token-backed exception component even though protected product history already delivers shared StatusNotice under ADR 0220 / #643. The focused RED requires the matrix to acknowledge StatusNotice and rejects that obsolete claim.

The causal edit changes one matrix row: protected product already delivers StatusNotice; the remaining gap is complete Storybook/browser/a11y evidence for success, unavailable, retry, and permission states. It reuses the existing component rather than creating a second exception authority. Historical overlays remain history and are not rewritten.

Verified repair and promotion

The first isolated run 34003486164 reached the product repair and passed the focused contract plus one-addition/one-deletion causal-diff checks, then failed only because its self-removing harness counted its own workflow deletion. That harness defect was repaired non-force.

Follow-up run 34007470247 completed GREEN and produced clean staging commit f12243c6b5513a5cb8b3cb43d2ba569da2f59697, tree 2d8f1ec5a06736b6875b115dc3e6114409a98b9a. With the product branch still at exact predecessor d44cd875a93cb929b6e30b744976d2c19e67d981, only that clean tree was recreated as product commit 308ebdfae50606127316fa8c51d772ea93327f64 and the branch was fast-forwarded without force. Temporary workflow history was not promoted.

The PR remains Draft. The new product-head Tests run 34009950635 is skipped by Draft lifecycle policy, so isolated GREEN is not relabeled as required exact-product-head GREEN and no independent approval is implied.

Signed-off-by: Codex <codex@localhost>
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as draft September 1, 2026 05:47

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Devin Review

Comment thread docs/product-technical-gap-baseline.md Outdated
Comment thread docs/product-technical-gap-baseline.md Outdated
Codex and others added 6 commits September 1, 2026 15:15
Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
Merge the current #780 root after it incorporated protected main@3f61c824. The parent movement only adds docs/index.md; this PR's product-gap baseline delta remains unchanged.
seonghobae and others added 5 commits September 2, 2026 15:50
Signed-off-by: Codex <codex@localhost>
Adopt #7800bf2440 after protected main #924 while preserving the one-file gap-baseline delta without force rewrite.
Adopt #7801d8fa26 after protected #931 while preserving this child's one-file gap-baseline delta. The child tree is rebuilt from the moved parent plus the exact prior baseline blob, without force rewrite or ancestry loss.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parent #780 moved to 1d8fa267b059289e77301a09985dfac70a439814 to adopt protected #931. This child was immediately reconstructed from that exact parent tree plus its prior baseline blob 42306548ea99983716098c141c61c0d3ee99da74, producing 9e582e4be080ae74bffac83817e639993ac85a71 without force rewrite. The one-file documentation delta is preserved. The independent ADR 0134 / shared StatusNotice semantic defect remains valid and is not resolved by ancestry convergence.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid semantic documentation finding: the ADR 0134 row in docs/product-technical-gap-baseline.md still says there is “no shared token-backed exception component,” while protected product history already contains shared StatusNotice (ADR 0220 / delivered #643) and AGENTS explicitly describes StatusNotice as shared success/unavailable/retry copy. This is stale buyer-gap classification, not historical evidence that should be preserved as current truth. Add an executable documentation RED that rejects the obsolete claim, then update only the ADR 0134 row; keep the dated historical overlays untouched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant