feat(reports): leftover-map incomplete posts on grouping comparison graphic (v2.65.0) - #848
Conversation
…raphic (v2.65.0) Caption leftover-map incomplete post coverage on the grouping comparison leftover-map graphic from already-named leftover_map_coverage (ADR 0308). Distinct accessible name Leftover map comparison graphic incomplete posts. Omit incomplete item notes on that comparison plot. Never invent a leftover score or a theta.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Write probe after open. Independent APPROVE is required. This comment is not a review. The only repository collaborator is seonghobae, so an independent reviewer cannot be requested this cycle. Copilot/Devin COMMENT is not independent APPROVE. Leave open. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (#782) rather than squash-merging here. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
📝 Info: Contradictory coverage remains isolated
leftoverMapIncompletePostCount suppresses mismatched dropped counts without suppressing independently valid post or item captions.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
| {incompletePostCount !== null ? ( | ||
| <p | ||
| className="leftover-map-plot-incomplete-posts" | ||
| role="note" | ||
| aria-label={t(LEFTOVER_MAP_PLOT_INCOMPLETE_POST_LABEL)} | ||
| aria-label={t( | ||
| variant === "comparison" | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_POST_LABEL | ||
| : LEFTOVER_MAP_PLOT_INCOMPLETE_POST_LABEL, | ||
| )} | ||
| > | ||
| {tf(LEFTOVER_MAP_PLOT_INCOMPLETE_POST, incompletePostCount)} | ||
| </p> |
There was a problem hiding this comment.
📝 Info: Variant labels remain distinct
Comparison plots receive the new accessible name. Report plots retain their existing name, and comparison plots still omit incomplete-item coverage.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Caption persisted leftover-map incomplete-post coverage on the grouping-comparison leftover-map graphic when
leftoverMapIncompletePostCountreturns a usable dropped count (ADR 0308 / v2.65.0). It omits independently from post/item complete-case coverage. No SQL/new columns; never synthesize dropped posts from scored-minus-used or other plot statistics.Live authority
#846@e80832830fed438451e9f2785b7a75b2fd1745a64fd48d00e0473160ed05ecd5d168598ba5d688f54, behind0Parent convergence
#848 inherited
tests/test_compare_graphic_adr_status.pyaseef2dca3471b5482e276aa02683a2815698d4740. GitHub then produced exact current-parent merge3f0a04c98acef603f03812514b02654f9e6eb882, verified with parents#846@e8083283...and#848@eef2dca.... Its tree preserves ADR 0308/v2.65.0 and the ADR0305–0308 amendment chain while keeping ADR 0304Proposed. The same tree was recorded child-first as4fd48d00...; branch movement was non-force only.Historical
476-test/oxlint/py_compile evidence predates this exact head and is not transferred. Exact-head required/frontend/browser/a11y and PostgreSQL/k6 evidence plus independent approval remain outstanding. Any direct descendant must be reconstructed before predecessor evidence transfers.Product invariants
0remains valid when persisted counts satisfy the contract.Keep Draft until exact-head evidence and independent approval exist. No self-approval, gate bypass, force push, or destructive rebase.