feat(reports): leftover-map item coverage on grouping comparison graphic (v2.64.0) - #846
Conversation
…hic (v2.64.0) Caption leftover-map item complete-case coverage on the grouping comparison leftover-map graphic from already-named leftover_map_coverage (ADR 0307). Distinct accessible name Leftover map comparison graphic item coverage. Omit incomplete notes on that comparison plot. Never invent a leftover score or a theta.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Write probe after open. Independent APPROVE is required. This comment is not a review. The only repository collaborator is seonghobae, so an independent reviewer cannot be requested this cycle. Copilot/Devin COMMENT is not independent APPROVE. Leave open. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (#782) rather than squash-merging here. |
There was a problem hiding this comment.
📝 Info: Coverage validation remains independent
leftoverMapCoverageCounts and leftoverMapItemCoverageCounts validate separate fields. A malformed count suppresses only its own comparison-graphic caption.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
📝 Info: Captions cannot outlive the graphic
layoutLeftoverMapPlot gates the entire figure before coverage rendering. Missing plottable coordinates omit both the comparison graphic and its item caption.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Stacked next increment opened as leftover-map incomplete post coverage on the grouping comparison leftover-map graphic (ADR 0308 / v2.65.0) on |
Summary
Caption persisted leftover-map item complete-case coverage on the grouping-comparison leftover-map graphic when
leftoverMapItemCoverageCountsreturns usable integers (ADR 0307 / v2.64.0). Post and item coverage omit independently. No SQL/new columns; never infer item coverage from marker/pair counts or other leftover-map statistics.Live authority
#845@8d37896a5246cd0045a9c210b504b95941a78f84e80832830fed438451e9f2785b7a75b2fd1745a64, behind0Parent convergence
#846 first inherited
tests/test_compare_graphic_adr_status.pyas63b3e7d610776a60900e7528912d57038e2890de. GitHub then produced current-parent merge595e929a94278928a953d0cf31be9886fd156d10with exact parents#845@8d37896...and#846@63b3e7d...; that GitHub-verified tree preserved ADR 0307/v2.64.0 while keeping ADR 0304Proposedand its regression. The same tree was recorded as child-first two-parent commite8083283..., and the product branch moved by non-force fast-forward only.Historical
470-test/oxlint/py_compile evidence predates this exact head and is not transferred. Exact-head required/frontend/browser/a11y and PostgreSQL/k6 evidence plus independent approval remain outstanding. Direct descendant #848 must be reconstructed against this head before predecessor evidence can transfer.Product invariants
0 of Mis valid when stored counts satisfy the contract.Keep Draft until exact-head evidence and independent approval exist. No self-approval, gate bypass, force push, or destructive rebase.