Skip to content

feat(reports): leftover-map item coverage on grouping comparison graphic (v2.64.0) - #846

Draft
seonghobae wants to merge 4 commits into
feat/leftover-map-compare-plot-coverage-v2630from
feat/leftover-map-compare-plot-item-coverage-v2640
Draft

feat(reports): leftover-map item coverage on grouping comparison graphic (v2.64.0)#846
seonghobae wants to merge 4 commits into
feat/leftover-map-compare-plot-coverage-v2630from
feat/leftover-map-compare-plot-item-coverage-v2640

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Caption persisted leftover-map item complete-case coverage on the grouping-comparison leftover-map graphic when leftoverMapItemCoverageCounts returns usable integers (ADR 0307 / v2.64.0). Post and item coverage omit independently. No SQL/new columns; never infer item coverage from marker/pair counts or other leftover-map statistics.

Live authority

  • parent/base: #845@8d37896a5246cd0045a9c210b504b95941a78f84
  • current product head: e80832830fed438451e9f2785b7a75b2fd1745a6
  • compare from parent: ahead 4, behind 0
  • PR: open / Draft

Parent convergence

#846 first inherited tests/test_compare_graphic_adr_status.py as 63b3e7d610776a60900e7528912d57038e2890de. GitHub then produced current-parent merge 595e929a94278928a953d0cf31be9886fd156d10 with exact parents #845@8d37896... and #846@63b3e7d...; that GitHub-verified tree preserved ADR 0307/v2.64.0 while keeping ADR 0304 Proposed and its regression. The same tree was recorded as child-first two-parent commit e8083283..., and the product branch moved by non-force fast-forward only.

Historical 470-test/oxlint/py_compile evidence predates this exact head and is not transferred. Exact-head required/frontend/browser/a11y and PostgreSQL/k6 evidence plus independent approval remain outstanding. Direct descendant #848 must be reconstructed against this head before predecessor evidence can transfer.

Product invariants

  • Missing/invalid item coverage omits only the comparison graphic item-coverage caption.
  • Post and item coverage omit independently; 0 of M is valid when stored counts satisfy the contract.
  • Existing axis-share and post-coverage display remain independent.
  • This increment does not add incomplete coverage captions.

Keep Draft until exact-head evidence and independent approval exist. No self-approval, gate bypass, force push, or destructive rebase.

…hic (v2.64.0)

Caption leftover-map item complete-case coverage on the grouping comparison leftover-map graphic from already-named leftover_map_coverage (ADR 0307). Distinct accessible name Leftover map comparison graphic item coverage. Omit incomplete notes on that comparison plot. Never invent a leftover score or a theta.
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Write probe after open. Independent APPROVE is required. This comment is not a review. The only repository collaborator is seonghobae, so an independent reviewer cannot be requested this cycle. Copilot/Devin COMMENT is not independent APPROVE. Leave open. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (#782) rather than squash-merging here.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Devin Review

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Coverage validation remains independent

leftoverMapCoverageCounts and leftoverMapItemCoverageCounts validate separate fields. A malformed count suppresses only its own comparison-graphic caption.

(Refers to this code)

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Captions cannot outlive the graphic

layoutLeftoverMapPlot gates the entire figure before coverage rendering. Missing plottable coordinates omit both the comparison graphic and its item caption.

(Refers to this code)

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Contributor Author

Stacked next increment opened as leftover-map incomplete post coverage on the grouping comparison leftover-map graphic (ADR 0308 / v2.65.0) on feat/leftover-map-compare-plot-incomplete-post-v2650 @ 6707725. Distinct accessible name Leftover map comparison graphic incomplete posts. Leave #846 and the stacked increment open for independent review. Do not squash-merge. This comment is not a review.

@seonghobae
seonghobae marked this pull request as draft September 4, 2026 08:06
Adopt the conflict-free GitHub test-merge tree for exact parent #845 4e82102 while preserving existing #846 product head 4779764 as first-parent ancestry. No force push and no product delta is dropped.
seonghobae added a commit that referenced this pull request Sep 6, 2026
Adopt the conflict-free GitHub test-merge tree for exact parent #846 98bd2bd while preserving existing #848 product head 6707725 as first-parent ancestry. No force push and no product delta is dropped.
Adopt the verified conflict-free GitHub merge tree for exact parent #8458d37896 and child 63b3e7d. The tree preserves ADR 0307/v2.64.0 and inherits ADR 0304 Proposed plus its regression. No force push and no valid delta is dropped.
seonghobae added a commit that referenced this pull request Sep 6, 2026
Adopt the GitHub-verified conflict-free merge tree for exact parent #846e808328 and child eef2dca. The tree preserves ADR 0308/v2.65.0 and inherits ADR 0304 Proposed plus its regression. No force push and no valid delta is dropped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant