๐จ Palette: ์ธ๋ถ ๋งํฌ ํดํ ๋ค๊ตญ์ด ์ง์ ์ถ๊ฐ #197
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ const messages = { | |
| metaDescription: "๋งฅ๋ฝ์งํ ์ฐ๊ตฌ์ค์ ํฉ์ด์ง ๊ธฐ์ ์๋ฃ๋ฅผ ๋งฅ๋ฝ ์์์ ํ๋จ ๊ฐ๋ฅํ ๊ตฌ์กฐ๋ก ๋ฐ๊พธ๋ AI ์์ฌ๊ฒฐ์ ์ง์ ์์คํ ์ ์ฐ๊ตฌํ๊ณ ๋ง๋ญ๋๋ค.", | ||
| logoSrc: "assets/context-wisdom-lab-logo.svg", | ||
| logoAlt: "๋งฅ๋ฝ์งํ ์ฐ๊ตฌ์ค ยท Contextual Wisdom Lab", | ||
| "common.newTab": "์ ์ฐฝ์์ ์ด๊ธฐ", | ||
|
There was a problem hiding this comment. ๐ Info: Tooltip wording: window vs tab The Korean 
Was this helpful? React with ๐ or ๐ to provide feedback. |
||
| "nav.intro": "์๊ฐ", | ||
| "nav.problem": "๋ฌธ์ ์์", | ||
| "nav.model": "์ฐ๊ตฌ๋ชจํ", | ||
|
|
@@ -151,6 +152,7 @@ const messages = { | |
| metaDescription: "A research lab building AI decision support systems that connect scattered enterprise material into judgment inside concrete contexts.", | ||
| logoSrc: "assets/context-wisdom-lab-logo-en.svg", | ||
| logoAlt: "Contextual Wisdom Lab", | ||
| "common.newTab": "Opens in new tab", | ||
| "nav.intro": "Intro", | ||
| "nav.problem": "Problem", | ||
| "nav.model": "Research Model", | ||
|
|
@@ -365,14 +367,22 @@ function setLanguage(lang) { | |
|
|
||
| if (!isInitialDefault) { | ||
| if (!i18nNodes) { | ||
| i18nNodes = document.querySelectorAll("[data-i18n], [data-i18n-title]"); | ||
| } | ||
|
|
||
| // Only update textContent if it actually changed to avoid layout recalculations | ||
| i18nNodes.forEach((node) => { | ||
| if (node.hasAttribute("data-i18n")) { | ||
| const newText = dict[node.dataset.i18n]; | ||
| if (newText && node.textContent !== newText) { | ||
| node.textContent = newText; | ||
| } | ||
| } | ||
| if (node.hasAttribute("data-i18n-title")) { | ||
| const newTitle = dict[node.dataset.i18nTitle]; | ||
| if (newTitle && node.getAttribute("title") !== newTitle) { | ||
| node.setAttribute("title", newTitle); | ||
| } | ||
| } | ||
| }); | ||
| } | ||
|
Comment on lines
367
to
388
There was a problem hiding this comment. ๐ Info: Korean-default skip relies on inlined titles matching the dictionary The initial-load fast path skips all (Refers to this code)
Was this helpful? React with ๐ or ๐ to provide feedback. |
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ก User-facing change missing CHANGELOG entry
This PR adds a user-facing feature (translated
titletooltips on external links) via the newcommon.newTabkey but leavesCHANGELOG.mduntouched. The repository convention requires a Korean entry under[Unreleased]for every user-facing change.Prompt for agents
Was this helpful? React with ๐ or ๐ to provide feedback.