π¨ Palette: μΈλΆ λ§ν¬ ν΄ν λ€κ΅μ΄ μ§μ μΆκ° - #197
π¨ Palette: μΈλΆ λ§ν¬ ν΄ν λ€κ΅μ΄ μ§μ μΆκ°#197seonghobae wants to merge 5 commits into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. π WalkthroughWalkthroughμΈλΆ λ§ν¬μ μ ν μλ΄ ν΄νμ μΆκ°νμ΅λλ€. νκ΅μ΄μ μμ΄ λ²μμ λ±λ‘νμ΅λλ€. μΈμ΄ λ³κ²½ μ λ§ν¬μ Changesμ ν μλ΄ νμ§ν
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: βͺ Minimal Β· up to This change adds localized tooltips to external links that open in a new tab without affecting application data, permissions, or runtime dependencies. No actionable merge-blocking risk remains after normal checks and review. π₯ Pre-merge checks | β 4 | β 1β Failed checks (1 warning)
β Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 unsupported.)
β¨ Finishing Touches π‘ 2π Generate docstrings π‘
π οΈ Fix failing CI checks π‘
π§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| metaDescription: "λ§₯λ½μ§ν μ°κ΅¬μ€μ ν©μ΄μ§ κΈ°μ μλ£λ₯Ό λ§₯λ½ μμμ νλ¨ κ°λ₯ν κ΅¬μ‘°λ‘ λ°κΎΈλ AI μμ¬κ²°μ μ§μ μμ€ν μ μ°κ΅¬νκ³ λ§λλλ€.", | ||
| logoSrc: "assets/context-wisdom-lab-logo.svg", | ||
| logoAlt: "λ§₯λ½μ§ν μ°κ΅¬μ€ Β· Contextual Wisdom Lab", | ||
| "common.newTab": "μ μ°½μμ μ΄κΈ°", |
There was a problem hiding this comment.
π‘ User-facing change missing CHANGELOG entry
This PR adds a user-facing feature (translated title tooltips on external links) via the new common.newTab key but leaves CHANGELOG.md untouched. The repository convention requires a Korean entry under [Unreleased] for every user-facing change.
Prompt for agents
The repository convention (CLAUDE.md) requires CHANGELOG.md to be updated in Korean under the [Unreleased] section for any user-facing change. This PR introduces user-visible translated tooltips (title attribute) on external links via the new common.newTab i18n key, but CHANGELOG.md was not updated. Add a Korean [Unreleased] entry to CHANGELOG.md describing the addition of multilingual external-link tooltips.
Was this helpful? React with π or π to provide feedback.
|
|
||
| if (!isInitialDefault) { | ||
| if (!i18nNodes) { | ||
| i18nNodes = document.querySelectorAll("[data-i18n]"); | ||
| i18nNodes = document.querySelectorAll("[data-i18n], [data-i18n-title]"); | ||
| } | ||
|
|
||
| // Only update textContent if it actually changed to avoid layout recalculations | ||
| i18nNodes.forEach((node) => { | ||
| const newText = dict[node.dataset.i18n]; | ||
| if (newText && node.textContent !== newText) { | ||
| node.textContent = newText; | ||
| if (node.hasAttribute("data-i18n")) { | ||
| const newText = dict[node.dataset.i18n]; | ||
| if (newText && node.textContent !== newText) { | ||
| node.textContent = newText; | ||
| } | ||
| } | ||
| if (node.hasAttribute("data-i18n-title")) { | ||
| const newTitle = dict[node.dataset.i18nTitle]; | ||
| if (newTitle && node.getAttribute("title") !== newTitle) { | ||
| node.setAttribute("title", newTitle); | ||
| } | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
π Info: Korean-default skip relies on inlined titles matching the dictionary
The initial-load fast path skips all data-i18n-title nodes when the resolved language is Korean, so inlined title="μ μ°½μμ μ΄κΈ°" values are trusted to match messages.ko['common.newTab']. They currently match; any future drift would silently go uncorrected on first load.
(Refers to this code)
Was this helpful? React with π or π to provide feedback.
| metaDescription: "λ§₯λ½μ§ν μ°κ΅¬μ€μ ν©μ΄μ§ κΈ°μ μλ£λ₯Ό λ§₯λ½ μμμ νλ¨ κ°λ₯ν κ΅¬μ‘°λ‘ λ°κΎΈλ AI μμ¬κ²°μ μ§μ μμ€ν μ μ°κ΅¬νκ³ λ§λλλ€.", | ||
| logoSrc: "assets/context-wisdom-lab-logo.svg", | ||
| logoAlt: "λ§₯λ½μ§ν μ°κ΅¬μ€ Β· Contextual Wisdom Lab", | ||
| "common.newTab": "μ μ°½μμ μ΄κΈ°", |
There was a problem hiding this comment.
π Info: Tooltip wording: window vs tab
The Korean common.newTab reads 'μ μ°½μμ μ΄κΈ°' (new window) while the English reads 'Opens in new tab'. Harmless wording mismatch between locales.
Was this helpful? React with π or π to provide feedback.
1 participant
π‘ What:
target="_blank"μμ±μ κ°μ§ μΈλΆ λ§ν¬μ λν΄ λ§μ°μ€ μ€λ² μ λνλλ λ€κ΅μ΄ μ§μ ν΄ν(titleμμ±)μ μΆκ°νμ΅λλ€.π― Why: μ νμμ μ΄λ¦¬λ λ§ν¬μμ μ¬μ©μμκ² λͺ νν μλ΄νμ¬ νΌλμ λ°©μ§νκ³ μμΈ‘ κ°λ₯ν λΈλΌμ°μ§ κ²½νμ μ 곡νκΈ° μν΄μμ λλ€.
πΈ Before/After: μΈλΆ λ§ν¬ λ§μ°μ€ μ€λ² μ μ무 μλ΄κ° μμμΌλ, μ΄μ "μ μ°½μμ μ΄κΈ°"(EN: "Opens in new tab") ν΄νμ΄ νμλ©λλ€.
βΏ Accessibility: μ€ν¬λ¦° 리λ μ¬μ©μμκ² λ§ν¬ λμμ λν μΆκ° 컨ν μ€νΈλ₯Ό μ 곡νλ©°, μκ° μ₯μ μΈ λ° μΈμ§ μ₯μ λ₯Ό κ°μ§ μ¬μ©μλ€μ νμ κ²½νμ λμ΅λλ€.
PR created automatically by Jules for task 12589893808415607769 started by @seonghobae
Summary by CodeRabbit
μ κ·Όμ± κ°μ
λ¬Έμ