Skip to content

fix(noema): accept refreshed GitHub App publication identity #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

fix(noema): accept refreshed GitHub App publication identity #1647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions tests/test_noema_refreshed_app_identity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
"""Regression coverage for refreshed Noema GitHub App credentials."""

from scripts.ci import noema_review_gate as noema


def test_current_actor_accepts_refreshed_github_app_binding(monkeypatch):
"""A renewed installation token keeps the same independently bound App actor."""
monkeypatch.setenv("NOEMA_REVIEW_ACTOR", "cwl-noema-review[bot]")
monkeypatch.setenv("NOEMA_REVIEW_INSTALLATION_ID", "146401636")
monkeypatch.setenv(
"NOEMA_REVIEW_TOKEN_SOURCE",
"noema-review-github-app-refresh",
)
monkeypatch.setattr(
noema,
"run",
lambda *args, **kwargs: (_ for _ in ()).throw(
AssertionError("bound GitHub App metadata should avoid API fallback")
),
)

assert noema.current_actor() == "cwl-noema-review[bot]"
Loading