fix(noema): accept refreshed GitHub App publication identity - #1647
Closed
seonghobae wants to merge 1 commit into
Closed
fix(noema): accept refreshed GitHub App publication identity#1647seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incident
ContextualWisdomLab/appguardrailrun33553871167, job100009806999completed model review and minted a fresh repository-scopedcwl-noema-reviewinstallation token, then failed during exact-head publication withNoema GitHub App identity binding is invalid.Confirmed root cause
The publication step intentionally labels the renewed credential
noema-review-github-app-refresh.scripts/ci/noema_review_gate.py::current_actor()accepts bound App metadata only when the source is exactlynoema-review-github-app, so the refreshed credential is rejected despite the same valid bot actor and numeric installation ID.TDD state
This first commit contains only a focused regression test using the production incident metadata. It is expected to fail on the unchanged protected-main implementation. After RED evidence is recorded, the implementation will be changed minimally while retaining bot-login and numeric-installation fail-closed checks.
Scope
The existing long-running PR #1198 also touches
noema_review_gate.py, but its delta concerns primary-review ordering and review pagination; it does not modify this identity binding. This repair remains isolated to the refreshed-token contract.