Skip to content

Preserve accepted conflicting Sharp and librsvg versions - #14

Merged
CompleteDotTech merged 1 commit into
mainfrom
fix/audit-12-conflict-evidence
Oct 26, 2026
Merged

CompleteDotTech merged 1 commit into
mainfrom
fix/audit-12-conflict-evidence

Conversation

@CompleteDotTech

Copy link
Copy Markdown
Contributor

Fixes #12

Distinct accepted conflicting version pairs previously produced identical reports. Retain each component's bounded, sorted, deduplicated exact version observations in its existing evidence detail across JSON, CSV and HTML. Conflicts still have no selected version and remain unknown with exploitability=not_tested; malformed and qualified raw strings remain suppressed. The existing schema 1.0 shape is preserved. Documentation, synthetic HTML example, standalone checker and checksums are updated together.

Validation: original defect reproduced on current main with two byte-identical distinct conflicts. 78 offline tests pass (3 Windows platform skips), including five new regression tests covering both components/all formats, distinct conflict pairs, secret-bearing/qualified suppression, duplicate ordering, and maximum input bounds. Deterministic build check, CLI help and git diff --check pass. No network scanning, application execution, decoding or exploit probes. Signed commit. Exact-head CI and completed hosted Copilot review are required before merge.

Copy link
Copy Markdown
Contributor Author

Hosted review gate is currently blocked for head 56f2605. The GitHub connector and direct documented REST request for copilot-pull-request-reviewer[bot] returned success (direct REST HTTP 201), but requested users/teams remain empty, the timeline has no review_requested event, and completed reviews/review threads are empty. This is not review registration or a clean review. This PR must remain unmerged until a hosted Copilot review of the exact final head completes and any actionable findings are resolved. Local validation is separate: 78 offline tests pass (3 platform skips), deterministic build check, CLI help and whitespace checks pass; hosted CI readback will be recorded separately.

Copy link
Copy Markdown
Contributor Author

Exact-head hosted CI readback: all 12 checks passed for signed head 56f2605, covering Python 3.10/3.14 on Ubuntu, Windows and macOS for push and PR events. Runs: https://github.com/CompleTetech-Security/sharp-rsvg-rce-check/actions/runs/40254019122 and https://github.com/CompleTetech-Security/sharp-rsvg-rce-check/actions/runs/40254035977 . Required hosted Copilot review remains unavailable as documented above; no merge or issue closure is warranted.

@CompleteDotTech
CompleteDotTech merged commit ecb2d54 into main Oct 26, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] Preserve accepted conflicting versions in report evidence

1 participant