Skip to content

Retain run assessment and exact checker provenance in every report - #15

Merged
CompleteDotTech merged 3 commits into
mainfrom
fix/audit-13-report-provenance
Oct 26, 2026
Merged

CompleteDotTech merged 3 commits into
mainfrom
fix/audit-13-report-provenance

Conversation

@CompleteDotTech

Copy link
Copy Markdown
Contributor

Fixes #13

Reports previously lacked an assessment timestamp and exact executing-build identity; CSV additionally discarded tool and rule snapshot provenance. Capture one UTC run assessment time and standalone SHA-256, reuse them through handled interruption recovery, and retain tool/rule identity and completeness across JSON/CSV/HTML, including empty summaries. Assessment time remains separate from rule verification/evidence acquisition, and executable identity never attests a deployed patch.

Update the closed report schema, renderers, deterministic injected-context fixtures, documentation, generated standalone executable, checksums and synthetic HTML together. CSV summary provenance remains formula-neutralized.

Validation: five new regression methods fail unchanged parent; 83 synthetic offline tests successful (three Windows platform skips), deterministic build check, CLI help and full committed whitespace check pass. No network scans, application execution, image decoding or production changes.

Stacked dependency: parent PR #14 at exact 56f260560eb3710596fe5c90ca40186918324802, base fix/audit-12-conflict-evidence. That PR must actually merge before this PR is reconciled and eligible to merge. Hosted exact-head Copilot review and CI are required; local review or silence does not satisfy them.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T03:39:37.196585Z 0ad73dc Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@CompleteDotTech

Copy link
Copy Markdown
Contributor Author

Final signed head ad6885c5caa77b696ff774eed462bb79510ca32a: all 12 exact-head hosted CI jobs passed; 83 local tests successful (three platform skips), deterministic build, CLI help, schema parity, generated checksums and full commit whitespace check passed.

The actual hosted GitHub Copilot reviewer request used the documented copilot-pull-request-reviewer[bot] REST route and returned success, but registered users/teams remain empty. Delayed readback shows no review-requested timeline event, completed review or inline review finding. This is not a completed clean review. PR remains unmerged and issue open.

Stacked dependency remains parent PR #14 at exact 56f260560eb3710596fe5c90ca40186918324802; its actual merge and subsequent reconciliation are required before this PR can merge. No branch protection bypass or deployment performed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad6885c5ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vendor/common.py Resolved
@CompleteDotTech

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 3c52a2800e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@CompleteDotTech

Copy link
Copy Markdown
Contributor Author

Symlink remediation final head: 3c52a2800e106d93e451d8ef3b5d6a1aeea2138b (signed).

The valid hosted Codex P2 finding is fixed: resolve only the executing checker path before its bounded digest read. Synthetic modified-copy and symlink subprocess regression failed on the prior head under Linux and passes after the fix; evidence/output symlink restrictions remain enforced. Windows suite: 84 tests successful, four platform skips. Native Linux: six provenance tests passed. Build/checksum and committed diff checks passed; all 12 exact-head CI jobs passed.

Hosted Codex completed review of this exact head with no findings: #15 (comment) . The original finding has a verified evidence reply and resolved discussion. This supplemental review is not GitHub Copilot review.

The fresh documented Copilot bot request returned success but registered no reviewer, and no completed Copilot review exists. Required parent PR #14 remains open at 56f260560eb3710596fe5c90ca40186918324802. Both gates remain outstanding; this PR remains unmerged and issue #13 open.

@CompleteDotTech

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 0ad73dc189

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@CompleteDotTech
CompleteDotTech changed the base branch from fix/audit-12-conflict-evidence to main October 26, 2026 03:41
@CompleteDotTech
CompleteDotTech merged commit 5b5b904 into main Oct 26, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] Include observation time and build/rules provenance in every report format

1 participant