Skip to content

Preserve healthy siblings across image planning failures - #6

Merged
CompleteDotTech merged 1 commit into
mainfrom
fix/audit-3-sibling-planning
Oct 26, 2026
Merged

CompleteDotTech merged 1 commit into
mainfrom
fix/audit-3-sibling-planning

Conversation

@CompleteDotTech

Copy link
Copy Markdown
Contributor

Fixes #3

A malformed child OCI index or independent Docker-save image previously aborted all planning and discarded supported siblings. Validate child index structure inside its descriptor boundary, and turn individual Docker planning failures into incomplete records. Healthy siblings retain component and digest provenance in either order; rejected entries supply no consumer records. Root corruption and global budgets remain conservative.

Validation: both original cases reproduced against unchanged parent; 25 synthetic offline tests pass. New coverage checks structural child failures, missing/config/unsafe Docker members, reversed sibling order, consumer exclusion, nested-depth bounds and shared budget exhaustion. CLI help, committed checksum and diff checks pass. No images executed, archive extraction, registry or target access.

Stacked on #5, exact parent e66135f7194ee381f4adbf2340ba1aef869b4bd7. This PR must not merge before #5 actually merges and the final diff/review/CI are reconciled. Required hosted Copilot review and exact-head CI remain merge gates.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T03:03:58.221656Z 5924c5b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@CompleteDotTech

Copy link
Copy Markdown
Contributor Author

Exact head 5924c5b93b7b709f4c0845268af8cbb05b650967: 25 local synthetic tests pass, CLI help and committed diff checks pass; all 12 hosted push/PR matrix jobs pass across Linux, Windows and macOS on Python 3.10/3.14. No images executed, network targets accessed or archive members extracted.

Required hosted Copilot remains blocked: two documented REST requests for copilot-pull-request-reviewer[bot] return success, but readback has no requested user, no review_requested event, no submitted review and no review threads. Successful request responses are not review approval. This PR stays unmerged; issue #3 stays open.

Stack dependency: parent PR #5 must actually merge before this PR, followed by final diff/review/CI reconciliation. Its current immutable head is e66135f7194ee381f4adbf2340ba1aef869b4bd7.

@CompleteDotTech
CompleteDotTech changed the base branch from fix/audit-2-artifact-semantics to main October 26, 2026 03:36
@CompleteDotTech
CompleteDotTech merged commit ce5aea9 into main Oct 26, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] Preserve healthy siblings when child-index or Docker image planning fails

1 participant