Repository navigation
Record OCI generation provenance with linked consumer receipts - #7
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Validation at a270ba0: all 12 exact-head hosted CI checks pass (Ubuntu, Windows and macOS; Python 3.10 and 3.14 across push/PR events). Local validation: 31 tests pass; six provenance tests also pass on native Linux, including copied/symlinked standalone execution. The documented hosted Copilot reviewer request returned success, but the later readback has no requested reviewer, no review-request timeline event, no inline comments and no completed review. This is not clean approval. This PR remains unmerged pending actual hosted Copilot completion and coordinator review. Parent PR #6 (and its parent #5) must merge first. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a270ba09ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Both review findings are fixed at signed head 6136e1e. Their regression tests fail on the former head and pass now: interrupted receipt staging returns 130 and removes its private temporary file, and actual stdout bytes match the receipt SHA-256 despite Windows text translation settings. The evidence replies were verified and both discussions are resolved. Validation: all 33 local tests pass, all eight native Linux provenance tests pass, and all 12 exact-head hosted CI checks pass. The fresh hosted Codex review is still pending; the requested Copilot reviewer has not registered and no completed Copilot review exists. Neither pending/silent state is approval. Parent PR #6 and its parent #5 remain unmerged. This PR and issue remain open. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6136e1e64f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Fixes #4
Canonical inventory previously omitted when it was generated. Capture one UTC generation timestamp and bounded standalone executable identity per invocation, including incomplete/interrupted output. Retain a stable content digest that excludes generation time; existing artifact identities and uncertainty remain unchanged.
Consumer records keep their existing schemas. Optional --receipt writes the canonical evidence and exact export SHA-256 to a protected companion file; documentation describes publication ordering and partial-pair recovery limits.
Validation: 31 synthetic offline tests pass, including six provenance methods that fail on the unchanged parent. Tests cover injected clocks, complete/empty/invalid/interrupted results, consumer linking/no-clobber, and copied/symlinked standalone identity. CLI help, signed commit and committed diff checks pass. No Docker, registry access, image execution, or production scans.
Stacked on PR #6 at 5924c5b; that PR and its parent #5 must merge before this one. Required hosted Copilot review and exact-head CI remain merge gates.