feat: 1.4.5 release — governed recall, schema v8, Smart gateway - #111
Conversation
Release-ready 1.4.0: review-gated writes, prompt-eligibility enforcement, bounded adaptive context, schema v8 (confidence, pin lattice, tombstones), and the nine-tool Smart MCP gateway. Core: - schema v8: memories.confidence/pinned_at/unpinned_at + memory_tombstones, additive auto-migration on open (gated, idempotent) - governed recall: prompt-eligible gating on every ranking/capacity path, legacy provenance fallback, scoped canonical-seed expansion - conflict repair: deterministic conflicts_with relation + confidence discount clamped to never raise a neighbor's confidence - entity canonicalization: close two-hop chains to their root, gated to v4 - sync: tombstone dedupe (earliest-wins) + tombstones_applied in totals - v1: external /documents/upload now untrusted (poisoning gate) MCP: - Smart gateway (9 tools): session, recall, remember, discovery, read/action, get_memory, update_memory, conflict_review; stable error envelopes - classic 33-tool surface preserved via engraphis-mcp-classic Tests/quality: - 2788 collected; full suite green; 40/40 Playwright e2e green - ruff clean; eval gates recall@5 1.000; wheel/sdist build verified - docs: tool counts, schema v8, CHANGELOG reconciled with code Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ebf72ffcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Review fixes: - v2_api: narrow exception handler so no internal details reach the response (CodeQL) - mcp_server get_memory: enforce repo scope on links/chain (cross-repo title leak) - mcp_server get_memory: return real confidence from the inspected record - store: run entity canonicalization on every open + live token-overlap merge on upsert_entity (aliases now merge in normal operation, not only v4 migration) - scoring: drop non-finite arm scores before normalization (NaN no longer max) - docs: MCP_TOOLS/SKILL/ARCHITECTURE now list nine Smart tools; checksums updated Graph layout: - communities mode keeps origin-based centering so a released drag stays put (function-target community grid fought the drag-release e2e contract) - classic/static copies stay byte-identical Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
|
All six review findings are addressed in b96b2d0:
Local verification: full offline suite green, ruff clean, 40/40 Playwright e2e green (including the graph drag-release specs). |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b96b2d031d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…rejected Policy: every local-agent write is immediately prompt-eligible. The review gate now applies only to explicitly external/imported sources, and the deterministic poisoning guard still overrides approval for detected payloads (quarantine always wins, never hidden from the review inbox). - service: local-agent sources (agent, intent_api) create approved memories directly; external sources remain pending; quarantine overrides both - poisoning: apply_quarantine_metadata resets review_state to quarantined so a detected payload can never keep an approved label - engine: re-approving an approved record is an idempotent no-op - mcp: ingest uses the local-agent source path - docs: WRITE_REVIEW/MCP_TOOLS updated to the new boundary - tests: updated to the new policy; full suite green, ruff clean Also: - .dockerignore: drop BuildKit-incompatible character-class patterns (docker CI) - pi integration test: expect nine Smart tools - consolidate: exception type (not message) in client-facing error report (CodeQL) Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
Policy: memory creation needs no permission — only poisoned content is rejectedPushed in 31843ea. Every local-agent write is now immediately prompt-eligible; the review gate applies only to explicitly external/imported sources, and the deterministic poisoning guard still overrides approval for detected payloads (quarantine always wins and is never hidden from the review inbox). Also included in this push:
Local verification: full offline suite green, ruff clean, 40/40 Playwright e2e green. |
There was a problem hiding this comment.
💡 Codex Review
engraphis/engraphis/service.py
Line 4108 in 31843ea
Rebuild semantic indexes after changing the title
When title changes, this refreshes only FTS even though memory embeddings are created from title + "\n" + content. The portable vector and active ANN index therefore continue representing the old title, so semantic ranking remains stale for queries matching either the old or new title until a full embedding rebuild; re-embed the updated text and upsert both vector mirrors here.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- secrets: add redact_secrets() — PEM blocks, credential patterns, DSNs, and assignments become a safe marker (reject_secrets still fails closed for product writes; this is for callers that need a safe copy, e.g. eval corpora) - eval.external: LoCoMo/LongMemEval loaders redact source text before the fixture reaches the engine and report source_secret_redactions - pi: override hono >= 4.12.34 (npm audit moderate ReDoS in CORS middleware) - dockerignore: replace character-class pattern with plain globs (BuildKit "syntax error in pattern") Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 166a7fbd68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Coding-Dev-Tools
changed the title
Coding-Dev-Tools
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea7c8f1c6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…-111-review # Conflicts: # .claude-plugin/skill-assets.sha256 # CHANGELOG.md
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efa51fe85c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2bf95d063
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 873f0b3d1c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f0cc4cf07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e14ff3a4d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61698f739c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68196d852a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93f085a9b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
Release-ready 1.4.5: review-gated writes, prompt-eligibility enforcement, bounded adaptive context, schema v8 (confidence, pin lattice, tombstones), and the nine-tool Smart MCP gateway.
Core
MCP
Quality