Skip to content

fix: close remaining consolidation review findings - #113

Merged
Coding-Dev-Tools merged 6 commits into
mainfrom
codex/consolidation-followup-20260804
Aug 4, 2026
Merged

fix: close remaining consolidation review findings#113
Coding-Dev-Tools merged 6 commits into
mainfrom
codex/consolidation-followup-20260804

Conversation

@Coding-Dev-Tools

@Coding-Dev-Tools Coding-Dev-Tools commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Follow-up to merged PR #111. This branch carries bounded partial consolidation clusters across rotating windows, filters pending candidates through the live scoped predicate, enforces raw-row scan caps with bounded overlap cursors, and makes the ranking evaluation exercise the production bonus while preserving raw/source evidence quality.

Verification:

  • Full local pytest suite passed with exit code 0 and no failures.
  • Focused consolidation/cursor regression set: 6 passed.
  • Ruff and git diff checks: passed.
  • Consolidation-ranking eval: 2 cases; summary digest top-1 1.000 vs baseline 0.000; ranking-change rate 0.500; expected/raw/source hit@k all 1.000.
  • GitHub Actions: all 22 PR checks passed, including CodeQL, coverage, full offline stacks on Python 3.10–3.14, Windows/Pi extension, Docker health, browser accessibility, and repository hygiene.

All review threads are resolved.

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 317498e9a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/core/consolidate.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 118a25ae65

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/core/consolidate.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18b47506b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/core/consolidate.py
@Coding-Dev-Tools
Coding-Dev-Tools merged commit ec8c4c3 into main Aug 4, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant