Skip to content

Set internal_id for existing samples - #5307

Draft
islean wants to merge 6 commits into
masterfrom
allow-existing-samples-json
Draft

islean wants to merge 6 commits into
masterfrom
allow-existing-samples-json

Conversation

@islean

@islean islean commented Sep 10, 2026

Copy link
Copy Markdown
Member

Description

Closes #5137.

Added

Changed

  • Filling out existing_sample_name for a sample in the order form triggers us to set the internal_id for said sample, triggering the frontend and validation to treat it as an existing sample.

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@clingen-sthlm
clingen-sthlm temporarily deployed to stage September 10, 2026 14:53 Inactive
@clingen-sthlm
clingen-sthlm temporarily deployed to stage September 10, 2026 14:55 Inactive
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow existing samples to be specified in the JSON-orderforms

2 participants