Skip to content

Start external sample analyses when all samples are stored - #5299

Merged
diitaz93 merged 22 commits into
masterfrom
sample-stored-handler
Sep 7, 2026
Merged

Start external sample analyses when all samples are stored#5299
diitaz93 merged 22 commits into
masterfrom
sample-stored-handler

Conversation

@islean

@islean islean commented Sep 2, 2026 •
edited by diitaz93
Loading

Copy link
Copy Markdown
Member

Description

Implement a handler to start analyses involving external samples when all case samples have been ingested.

Added

  • external_sample_stored_handler that starts analyses for external samples
  • tests

Review

  • Tests executed by the mob
  • "Merge and deploy" approved by SD
    Thanks for filling in who performed the code review and the test!

This version is a

  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Deployed to stage:
Logging deploy ...
Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... done.
Log deploy... done.
cg, version 88.7.4
[js.diazboada@hasta:~] [S_base] $ up
  • Deployed to production:
Logging deploy ...
Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... done.
Log deploy... done.
cg, version 88.7.4
[js.diazboada@hasta:~] [P_base] $

diitaz93
diitaz93 reviewed Sep 3, 2026
View reviewed changes
Comment thread cg/services/events/event_handlers/external_sample_stored_handler.py Outdated
diitaz93
diitaz93 reviewed Sep 3, 2026
View reviewed changes
Comment thread cg/services/events/event_handlers/external_sample_stored_handler.py
islean
islean commented Sep 3, 2026
View reviewed changes
Comment thread cg/services/events/event_handlers/external_sample_stored_handler.py Outdated
islean
islean commented Sep 3, 2026
View reviewed changes
Comment thread cg/services/events/event_handlers/external_sample_stored_handler.py Outdated
islean
islean commented Sep 3, 2026
View reviewed changes
Comment thread tests/services/events/event_handlers/test_external_sample_stored_handler.py
islean
islean commented Sep 3, 2026
View reviewed changes

@islean islean left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can not approve my own PR

@diitaz93
diitaz93 marked this pull request as ready for review September 7, 2026 09:30
@diitaz93
diitaz93 requested a review from a team as a code owner September 7, 2026 09:30
@diitaz93 diitaz93 changed the title Sample stored handler Start external sample analyses when all samples are stored Sep 7, 2026
diitaz93
diitaz93 approved these changes Sep 7, 2026
View reviewed changes

@diitaz93 diitaz93 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud

sonarqubecloud Bot commented Sep 7, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@diitaz93
diitaz93 merged commit 309cbe6 into master Sep 7, 2026
8 checks passed
@diitaz93
diitaz93 deleted the sample-stored-handler branch September 7, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diitaz93 diitaz93 diitaz93 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@islean @diitaz93 @moedarrah @kedhammar