Skip to content

chore(file-architecture): 🤖 mono-repository migration#938

Open
punkbit wants to merge 10 commits intomainfrom
chore/monorepo-migration
Open

chore(file-architecture): 🤖 mono-repository migration#938
punkbit wants to merge 10 commits intomainfrom
chore/monorepo-migration

Conversation

@punkbit
Copy link
Collaborator

@punkbit punkbit commented Mar 23, 2026

Why?

The Click UI project is a single package that is growing to meet the needs of different consumer apps. As it grows, different concerns and priorities come into play.

For example, if it contained assets as a dependency, which are consumed through a stable API, it'd mean that when a new version of assets is released (e.g. 1.0.0 → 1.1.0), Click UI would automatically pick up the update without requiring consumer apps to take any action, as long as the new version falls within the compatible version range.

Furthermore, other concerns can be separated, such as design tokens, etc.

How?

  • Leverage yarn workspace for monorepo
  • Update GitHub Action/Workflows
  • Update supporting scripts

Preview?

N/A

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2026

⚠️ No Changeset found

Latest commit: 6f98dee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ClickHouse ClickHouse deleted a comment from github-actions bot Mar 23, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Mar 23, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Mar 23, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Mar 23, 2026
@github-actions
Copy link

github-actions bot commented Mar 23, 2026

Claude finished @punkbit's task in 1m 0s —— View job


PR Review: chore(file-architecture): 🤖 mono-repository migration

  • Read CLAUDE.md and conventions
  • Review key changed files (package.json, husky, workflows)
  • Post final review

Clean, well-structured monorepo migration. The previous review's concerns have all been addressed. Here's my final pass:

What's looking good:

  • Root package.json is properly minimal — private workspace root with topological orchestration scripts
  • .husky/pre-commit correctly delegates circular-dependency:check and changeset:verify to yarn workspace @clickhouse/click-ui
  • Workflow working-directory changes are consistently applied across publish.yml, release-publisher.yml, and create-release.yml
  • Changeset, script, and config files all correctly relocated under packages/click-ui/
  • Public @clickhouse/click-ui package API and exports are unchanged — no breaking changes

💡 Suggestions (non-blocking)

  • packages/click-ui/package.json (lines 487–490): "packageManager" and "engines" duplicate the root package.json. Safe to remove from the package-level file to avoid drift risk.

  • publish.yml (lines ~91–92): yarn test and yarn build run with working-directory: packages/click-ui, which bypasses root-level topological orchestration. Fine for the current single-package setup, but worth noting for when a second package is added that click-ui depends on.

This is ready to merge. Nice work! 🙌

@workflow-authentication-public
Copy link
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-ht5skba65-clickhouse.vercel.app

Built from commit: ab9e8b269e0ddc576bacc4d9bc0b6d43cfbad233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants