chore(monorepo): 🤖 make "assets" as package icons

[punkbit]

Why?

Make the assets a separate package of name icons.

⚠️ Depends on #938 (which should be merged first)

How?

• Move files from click-ui to its own packages/icon
• Create typescript conf
• Create aliases
• Support build scripts

Preview?

N/A

[changeset-bot]

⚠️ No Changeset found

Latest commit: f975b48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Claude finished @punkbit's task in 1m 24s —— View job

---

PR Review: chore(monorepo): 🤖 make "assets" as package icons

• Read CLAUDE.md and conventions
• Review changed files
• Post final review

---

Good progress since the last review — the previously-flagged must-fix issues have been addressed. Here's the current state:

---

✅ Previously flagged items — now resolved

• packages/icons/package.json convert script paths are correct (.scripts/js/convert-svg-to-react-component) ✓
• PaymentProps is now re-exported from @clickhouse/click-ui (line 35) ✓
• getAssetType([]) correctly calls process.exit(1) with an error message rather than crashing ✓

---

💡 Suggestions (non-blocking)

• Stale TODO lines — packages/icons/.scripts/js/convert-svg-to-react-component:3-4 still reads "TODO: Move to .scripts/js once PR chore: 🤖 clear scss setup (technical debt) #784 is merged" but the file is already at .scripts/js/. Safe to remove both lines. Fix this →

• IconName type duplication — packages/click-ui/src/components/Icon/Icon.types.ts:16 defines a local IconName as (typeof ICON_NAMES)[number] (a runtime-derived union from Object.keys(IconsLight)) while @clickhouse/icons also exports a static string-union IconName. The TODO at that line acknowledges this — worth a follow-up to settle on a single canonical type to avoid consumer confusion.

• Missing changeset — @clickhouse/icons is a new public package. Per CONVENTIONS.md, yarn changeset:add should be run before merging: at minimum a minor entry for @clickhouse/icons (new package) and a patch for @clickhouse/click-ui (internal refactor with re-exports).

---

Everything else looks solid — dual ESM/CJS build, sideEffects: false, granular sub-path exports, the config.ts deprecation/alias system, and the re-export layer in @clickhouse/click-ui are all well done. 🙌

[workflow-authentication-public]

📚 Storybook Preview Deployed

✅ Preview URL: https://click-bvb6xode5-clickhouse.vercel.app

Built from commit: 89a6065db6bb7fb2b8626a0868d6bf3f55a34fa4