Repository navigation
chore(smoke-tests): bump ClickHouse 25.12 -> 26.8 #3498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kodiakhq
merged 4 commits into
ClickHouse:main
from
Flipmonster:chore/smoke-test-clickhouse-26.8
Oct 30, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8e84c87
chore(smoke-tests): bump ClickHouse 25.12 -> 26.8
Flipmonster d497ecf
Merge branch 'main' into chore/smoke-test-clickhouse-26.8
pulpdrew ede56bc
test: Remove compat tests for now-unsuppported pre 26.2 versions
pulpdrew 29848d1
Merge branch 'main' into chore/smoke-test-clickhouse-26.8
pulpdrew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 0 additions & 7 deletions
7
smoke-tests/otel-collector/ch-compat-config.d/remove-prometheus-api.xml
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
smoke-tests/otel-collector/data/compat-schema/basic-insert/assert_query.sql
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
smoke-tests/otel-collector/data/compat-schema/basic-insert/expected.snap
This file was deleted.
Oops, something went wrong.
51 changes: 0 additions & 51 deletions
51
smoke-tests/otel-collector/data/compat-schema/basic-insert/input.json
This file was deleted.
Oops, something went wrong.
7 changes: 0 additions & 7 deletions
7
smoke-tests/otel-collector/data/compat-schema/index-types/assert_query.sql
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
smoke-tests/otel-collector/data/compat-schema/index-types/expected.snap
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 minor —
_assert_test_data_on_portindirection is now dead weightThe port parameter only existed for
assert_test_data_compat(port 29000). With that removed,assert_test_datais the only caller and always passes9000. Fold the body back intoassert_test_dataand hardcode port 9000 in it.Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond