Repository navigation
chore(smoke-tests): bump ClickHouse 25.12 -> 26.8 - #3498
Conversation
Aligns the otel-collector smoke test with the 26.8-alpine image used by the root, CI, dev and e2e compose files. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
|
@Flipmonster is attempting to deploy a commit to the HyperDX Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @Flipmonster, thanks for the pull request! Before we review code from a first-time contributor, a maintainer vouches for them, and you're not on our list yet. There's nothing else to file and this PR stays open — a maintainer will look at it, usually within a day or two, and vouch for you right here if it's a genuine attempt at the problem. To make that quick, check the PR description has:
More detail in our contributing guide. |
PR Review
2 finding(s): 🔴 0 critical · 🟠 1 major · 🔵 1 minor 1 posted as inline comment(s) on the changed lines. 1 listed below. Findings outside the changed lines
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Deep Review✅ No critical issues found. This is a test/CI-only change that cleanly removes the ClickHouse 25.12 compat-schema smoke-test harness. Removal is self-consistent: no dangling references to 🟡 P2 -- recommended
Reviewers (4): correctness, testing, maintainability, project-standards. Testing gaps: The compat schema-selection branch in the migrator ( No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
| _assert_test_data_on_port "29000" "$@" | ||
| } | ||
|
|
||
| _assert_test_data_on_port() { |
There was a problem hiding this comment.
🔵 minor — _assert_test_data_on_port indirection is now dead weight
The port parameter only existed for assert_test_data_compat (port 29000). With that removed, assert_test_data is the only caller and always passes 9000. Fold the body back into assert_test_data and hardcode port 9000 in it.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
smoke-tests/otel-collector/docker-compose.yamlis the only compose file still onclickhouse-server:25.12-alpine; the root, CI, dev and e2e compose files and the all-in-one Dockerfile are on 26.8 (an LTS line that has received the recent ClickHouse Server security fixes). This aligns it.Not run locally: the otel-collector smoke test should be run in CI. No changeset: test-only change.
🤖 Generated with Claude Code