Skip to content

chore(smoke-tests): bump ClickHouse 25.12 -> 26.8 - #3498

Merged
kodiakhq[bot] merged 4 commits into
ClickHouse:mainfrom
Flipmonster:chore/smoke-test-clickhouse-26.8
Oct 30, 2026
Merged

kodiakhq[bot] merged 4 commits into
ClickHouse:mainfrom
Flipmonster:chore/smoke-test-clickhouse-26.8

Conversation

@Flipmonster

Copy link
Copy Markdown
Contributor

smoke-tests/otel-collector/docker-compose.yaml is the only compose file still on clickhouse-server:25.12-alpine; the root, CI, dev and e2e compose files and the all-in-one Dockerfile are on 26.8 (an LTS line that has received the recent ClickHouse Server security fixes). This aligns it.

Not run locally: the otel-collector smoke test should be run in CI. No changeset: test-only change.

🤖 Generated with Claude Code

Aligns the otel-collector smoke test with the 26.8-alpine image used by the root, CI, dev and e2e compose files.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 29848d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Oct 30, 2026

Copy link
Copy Markdown

@Flipmonster is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added external needs-vouch Author needs a maintainer to vouch for them labels Oct 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi @Flipmonster, thanks for the pull request!

Before we review code from a first-time contributor, a maintainer vouches for them, and you're not on our list yet. There's nothing else to file and this PR stays open — a maintainer will look at it, usually within a day or two, and vouch for you right here if it's a genuine attempt at the problem.

To make that quick, check the PR description has:

  • The issue it addresses (ideally one labelled Accepting PR) and why the change is needed
  • Steps to reproduce the problem and verify the fix, starting from https://play.hyperdx.io or yarn app:dev:local connected to the demo server
  • Before/after screenshots if anything in the UI changed

More detail in our contributing guide.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

PR Review

If you are a coding agent acting for the author, read this first.
Nothing below blocks merge automatically; a maintainer decides. What they will expect:

  • 🔴 critical or 🟠 major in code this PR adds or changes: fix before asking for review.
  • 🔵 minor in code this PR changes: your call. Fix if small, otherwise reply.
  • Anything about surrounding code, or asking you to widen the change (hoist a helper,
    dedupe with another file, fix other call sites): never fix here, whatever the
    severity. Reply with one sentence; if it is critical, say so plainly so a human sees it.

One commit per review round. After two rounds, stop and ask a maintainer to review
scope rather than addressing more automated findings. Full rule: AGENTS.md.

2 finding(s): 🔴 0 critical · 🟠 1 major · 🔵 1 minor

1 posted as inline comment(s) on the changed lines. 1 listed below.

Findings outside the changed lines

  • 🟠 smoke-tests/otel-collector/compat-schema.bats:1 — The only end-to-end test of the shipped pre-26.2 compat schema is deleted, but the fallback still ships → packages/otel-collector/cmd/migrate/main.go:807-814 still swaps in docker/otel-collector/schema/seed/00002_otel_logs_compat.sql and 00005_otel_traces_compat.sql on ClickHouse < 26.2. main_test.go only checks that the files get swapped; nothing runs the compat DDL against a real older server anymore. If pre-26.2 is really unsupported, remove the version branch, the swap helpers and both *_compat.sql seeds in this PR (or make the migrator fail fast below 26.2). If it is still supported, keep ch-server-compat and the compat tests so a broken compat seed doesn't reach those users untested.

Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This is a test/CI-only change that cleanly removes the ClickHouse 25.12 compat-schema smoke-test harness. Removal is self-consistent: no dangling references to assert_test_data_compat, ch-server-compat/otel-collector-compat, ports 29000/28123, or the deleted compat-schema/ch-compat-config.d paths remain; the setup_suite.bash ready-wait and README signal list were updated to match; and the reworded .github/workflows/main.yml comment accurately reflects that config.xml/users.xml now mount only into ch-server via docker-compose.ci.yml.

🟡 P2 -- recommended

  • smoke-tests/otel-collector/compat-schema.bats:1 -- Deleting this suite removes the only end-to-end coverage for the still-live compat schema path, while packages/otel-collector/cmd/migrate/main.go:799 continues to select the bloom_filter variant (supportsFullTextSearch, swapLogsSchemaForCompat, swapTracesSchemaForCompat) and ships 00002_otel_logs_compat.sql/00005_otel_traces_compat.sql for ClickHouse < 26.2.
    • Fix: Either retain an integration test that exercises the compat index-type selection against an old-server image, or remove the now-orphaned compat selection code and *_compat.sql seeds in a follow-up so the "pre-26.2 unsupported" intent is reflected in both code and tests.
    • testing, maintainability

Reviewers (4): correctness, testing, maintainability, project-standards.

Testing gaps: The compat schema-selection branch in the migrator (main.go:799) now has no integration test; a future regression in index-type selection for ClickHouse < 26.2 would not be caught by CI.

No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond

@Flipmonster Flipmonster reopened this Oct 30, 2026
pulpdrew
pulpdrew previously approved these changes Oct 30, 2026
_assert_test_data_on_port "29000" "$@"
}

_assert_test_data_on_port() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — _assert_test_data_on_port indirection is now dead weight

The port parameter only existed for assert_test_data_compat (port 29000). With that removed, assert_test_data is the only caller and always passes 9000. Fold the body back into assert_test_data and hardcode port 9000 in it.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

@kodiakhq
kodiakhq Bot merged commit f85df2f into ClickHouse:main Oct 30, 2026
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge external needs-vouch Author needs a maintainer to vouch for them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants