Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nav-sentence-case.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@hyperdx/app': patch
---

fix: Use sentence case for sidebar nav labels, menus, and tooltips
12 changes: 6 additions & 6 deletions packages/app/src/components/AppNav/AppNav.components.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const AppNavCloudBanner = () => {
target="_blank"
rel="noopener noreferrer"
>
Get Started for Free
Get started for free
</Button>
</div>
</div>
Expand Down Expand Up @@ -155,15 +155,15 @@ export const AppNavUserMenu = ({
component={Link}
leftSection={<IconSettings size={16} />}
>
Team Settings
Team settings
</Menu.Item>
)}
<Menu.Item
data-testid="user-preferences-menu-item"
leftSection={<IconUserCog size={16} />}
onClick={onClickUserPreferences}
>
User Preferences
User preferences
</Menu.Item>
{logoutUrl && (
<>
Expand Down Expand Up @@ -287,7 +287,7 @@ export const AppNavHelpMenu = ({
target="_blank"
rel="noopener noreferrer"
>
Setup Instructions
Setup instructions
</Menu.Item>
<Menu.Item
data-testid="keyboard-shortcuts-menu-item"
Expand All @@ -304,7 +304,7 @@ export const AppNavHelpMenu = ({
target="_blank"
rel="noopener noreferrer"
>
Discord Community
Discord community
</Menu.Item>

<Menu.Divider />
Expand Down Expand Up @@ -396,7 +396,7 @@ export const AppNavLink = ({
)}
{!isCollapsed && onToggle && (
<Tooltip
label={isExpanded ? 'Hide Favorites' : 'Show Favorites'}
label={isExpanded ? 'Hide favorites' : 'Show favorites'}
position="right"
>
<button
Expand Down
14 changes: 7 additions & 7 deletions packages/app/src/components/AppNav/AppNav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ type NavLinkConfig = {
const NAV_LINKS: NavLinkConfig[] = [
{
id: 'chart',
label: 'Chart Explorer',
label: 'Chart explorer',
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Resolved
href: '/chart',
icon: <IconChartDots size={16} />,
},
Expand All @@ -96,13 +96,13 @@ const NAV_LINKS: NavLinkConfig[] = [
},
{
id: 'sessions',
label: 'Client Sessions',
label: 'Client sessions',
href: '/sessions',
icon: <IconDeviceLaptop size={16} />,
},
{
id: 'service-map',
label: 'Service Map',
label: 'Service map',
href: '/service-map',
icon: <IconSitemap size={16} />,
isBeta: true,
Expand Down Expand Up @@ -392,7 +392,7 @@ export default function AppNav({ fixed = false }: { fixed?: boolean }) {
className={cx(styles.collapseButton, {
[styles.collapseButtonCollapsed]: isCollapsed,
})}
title="Collapse/Expand Navigation"
title="Collapse/expand navigation"
onClick={() => setIsPreferCollapsed((v: boolean) => !v)}
>
<IconArrowBarToLeft size={16} />
Expand All @@ -417,7 +417,7 @@ export default function AppNav({ fixed = false }: { fixed?: boolean }) {

{/* Saved Searches */}
<AppNavLink
label="Saved Searches"
label="Saved searches"
href="/search/list"
icon={<IconDeviceFloppy size={16} />}
isActive={isSavedSearchActive}
Expand All @@ -434,7 +434,7 @@ export default function AppNav({ fixed = false }: { fixed?: boolean }) {
<Text size="xs" c="dimmed" pl="lg" pr="xs" py={4} lh={1.4}>
No favorites. Star on{' '}
<Anchor component={Link} href="/search/list" size="xs">
Saved Searches
Saved searches
</Anchor>
.
</Text>
Expand Down Expand Up @@ -499,7 +499,7 @@ export default function AppNav({ fixed = false }: { fixed?: boolean }) {
{/* Team Settings (Cloud only) */}
{!IS_LOCAL_MODE && (
<AppNavLink
label="Team Settings"
label="Team settings"
href="/team"
icon={<IconSettings size={16} />}
/>
Expand Down
Loading