Repository navigation
fix(app): use sentence case for sidebar nav labels - #3489
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: b7c61fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
PR Review✅ No issues found. |
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryChanges sidebar labels, menus, tooltips, and the cloud banner button to sentence case.
Reviews (3) · Last reviewed commit: "Merge branch 'main' into agent/nav-sente..." · Reviewed by Greptile |
E2E Test Results✅ All tests passed • 455 passed • 1 skipped • 1471s
Tests ran across 4 shards in parallel. |
Deep Review✅ No critical issues found. This PR is a purely cosmetic text change: it converts Title Case sidebar nav labels, menu items, tooltips, and the ClickHouse Cloud banner button to sentence case, matching the Verification performed:
Reviewers (3): correctness, project-standards, previous-comments. |
Summary
Some sidebar nav labels used Title Case and others used sentence case (
Search,Alerts,Dashboards,Keyboard shortcuts).agent_docs/code_style.mdsays all UI text should use sentence case, so this changes the Title Case ones to match. Only the text changes. Proper nouns stay as they are (ClickHouse Cloud).Changed strings:
Chart Explorer→Chart explorer,Client Sessions→Client sessions,Service Map→Service map,Saved Searches→Saved searches(the link and the "No favorites. Star on …" hint),Team Settings→Team settingsCollapse/Expand Navigation→Collapse/expand navigationHide Favorites/Show Favorites→Hide favorites/Show favoritesTeam Settings→Team settings,User Preferences→User preferencesSetup Instructions→Setup instructions,Discord Community→Discord communityGet Started for Free→Get started for freeNot changed here: the command palette, page titles (e.g.
usePageTitle('Chart Explorer')), and other pages.Nav test IDs come from
href(nav-link-chart,nav-link-sessions, …), and no unit or e2e test matches on the old text, so no tests needed updating.This makes the same change already made in the enterprise fork. The OSS nav is structured differently, so this is a separate patch for OSS, not a copy of the EE diff.
How to reproduce
Starting point:
yarn app:dev:local, then on onboarding click "Connect to Demo Server".On
main:Saved Searches,Chart Explorer,Client Sessions,Service Mapare Title Case, whileSearch,Alerts,Dashboardsare sentence case.Saved Searches. The tooltip readsShow Favorites/Hide Favorites.Help. The menu showsSetup InstructionsandDiscord Community.User Preferences.Collapse/Expand Navigation.Get Started for Free.On this branch:
Saved searches,Chart explorer,Client sessions,Service map,Show favorites,Setup instructions,Discord community,User preferences,Collapse/expand navigation,Get started for free).Team settings(sidebar link and user menu) only shows outside local mode, so useyarn devto check it.How to test on Vercel preview
Preview routes: /search
Steps:
Saved searches,Chart explorer,Client sessions, andService map.Helpand verify the menu showsSetup instructionsandDiscord community.User preferences.