Skip to content

fix(app): use sentence case for sidebar nav labels - #3489

Merged
kodiakhq[bot] merged 3 commits into
mainfrom
agent/nav-sentence-case
Oct 29, 2026
Merged

kodiakhq[bot] merged 3 commits into
mainfrom
agent/nav-sentence-case

Conversation

@brandon-pereira

@brandon-pereira brandon-pereira commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Summary

Some sidebar nav labels used Title Case and others used sentence case (Search, Alerts, Dashboards, Keyboard shortcuts). agent_docs/code_style.md says all UI text should use sentence case, so this changes the Title Case ones to match. Only the text changes. Proper nouns stay as they are (ClickHouse Cloud).

Changed strings:

  • Nav links: Chart Explorer → Chart explorer, Client Sessions → Client sessions, Service Map → Service map, Saved Searches → Saved searches (the link and the "No favorites. Star on …" hint), Team Settings → Team settings
  • Collapse button tooltip: Collapse/Expand Navigation → Collapse/expand navigation
  • Favorites toggle tooltip: Hide Favorites / Show Favorites → Hide favorites / Show favorites
  • User menu: Team Settings → Team settings, User Preferences → User preferences
  • Help menu: Setup Instructions → Setup instructions, Discord Community → Discord community
  • ClickHouse Cloud banner button: Get Started for Free → Get started for free

Not changed here: the command palette, page titles (e.g. usePageTitle('Chart Explorer')), and other pages.

Nav test IDs come from href (nav-link-chart, nav-link-sessions, …), and no unit or e2e test matches on the old text, so no tests needed updating.

This makes the same change already made in the enterprise fork. The OSS nav is structured differently, so this is a separate patch for OSS, not a copy of the EE diff.

How to reproduce

Starting point: yarn app:dev:local, then on onboarding click "Connect to Demo Server".

On main:

  1. Look at the left sidebar: Saved Searches, Chart Explorer, Client Sessions, Service Map are Title Case, while Search, Alerts, Dashboards are sentence case.
  2. Hover the chevron next to Saved Searches. The tooltip reads Show Favorites / Hide Favorites.
  3. Click Help. The menu shows Setup Instructions and Discord Community.
  4. Click the user menu at the bottom of the sidebar. It shows User Preferences.
  5. Hover the collapse button next to the logo. The tooltip reads Collapse/Expand Navigation.
  6. The ClickHouse Cloud banner button reads Get Started for Free.

On this branch:

  1. Repeat the steps above. All of those labels are now sentence case (Saved searches, Chart explorer, Client sessions, Service map, Show favorites, Setup instructions, Discord community, User preferences, Collapse/expand navigation, Get started for free).

Team settings (sidebar link and user menu) only shows outside local mode, so use yarn dev to check it.

How to test on Vercel preview

Preview routes: /search

Steps:

  1. Open /search.
  2. Verify the sidebar shows Saved searches, Chart explorer, Client sessions, and Service map.
  3. Click Help and verify the menu shows Setup instructions and Discord community.
  4. Click the user menu at the bottom of the sidebar and verify it shows User preferences.

@vercel

vercel Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Oct 29, 2026 9:03pm UTC
hyperdx-storybook Ready Ready Preview Oct 29, 2026 9:03pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b7c61fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 2
  • Production lines changed: 26
  • Branch: agent/nav-sentence-case
  • Author: brandon-pereira

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

PR Review

✅ No issues found.

@github-actions

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 114 in total (1.41%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Changes sidebar labels, menus, tooltips, and the cloud banner button to sentence case.

  • Sidebar and related controls use sentence case labels.

Reviews (3) · Last reviewed commit: "Merge branch 'main' into agent/nav-sente..." · Reviewed by Greptile

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 455 passed • 1 skipped • 1471s

Status Count
✅ Passed 455
❌ Failed 0
⚠️ Flaky 4
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@github-actions

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This PR is a purely cosmetic text change: it converts Title Case sidebar nav labels, menu items, tooltips, and the ClickHouse Cloud banner button to sentence case, matching the ## UI text: use sentence case rule in agent_docs/code_style.md. Only string literals change — no logic, props, data-testid attributes, href values, React keys, or analytics event names are touched.

Verification performed:

  • All changed strings correctly follow sentence case; proper nouns are preserved (ClickHouse Cloud, Discord).
  • No user-facing Title Case strings were missed in the two changed files — remaining strings (Search, Alerts, Dashboards, Documentation, Keyboard shortcuts) were already correct.
  • No unit or e2e test asserts on the changed nav strings via getByText/getByRole; nav test IDs derive from href, and e2e describe-block titles are unrelated test descriptions.
  • The one substantive prior review comment (Greptile: "Required changeset is missing") is resolved — this diff adds .changeset/nav-sentence-case.md declaring a @hyperdx/app patch, satisfying the AGENTS.md changeset requirement.

Reviewers (3): correctness, project-standards, previous-comments.

@kodiakhq
kodiakhq Bot merged commit 00768bb into main Oct 29, 2026
29 checks passed
@kodiakhq
kodiakhq Bot deleted the agent/nav-sentence-case branch October 29, 2026 21:10

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — b7c61fd3 Deployed Oct 29, 2026 by vercel[bot]
Preview – hyperdx-storybook — b7c61fd3 Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants