Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/actions/e2e-setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ runs:
# version, so it isn't re-downloaded every shard/run. Browser versions are
# pinned to the Playwright package version, so the version is the correct
# cache key. On a hit, `playwright install` finds the browser present and
# only installs OS deps.
# does nothing.
- name: Resolve Playwright version
id: playwright-version
shell: bash
Expand All @@ -62,9 +62,11 @@ runs:
${{ runner.os }}-playwright-${{
steps.playwright-version.outputs.version }}

# No --with-deps: the ubuntu-24.04 image already ships Chromium's shared

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — Dropping --with-deps relies on a runner image that nothing in the repo pins

The only caller, .github/workflows/e2e-tests.yml:11, runs on the larger-runner label 8-core-playwright, not ubuntu-24.04. That label's OS image is set in the org's runner settings, so the libraries Chromium needs are no longer guaranteed from inside the repo. If someone moves that runner to a newer or slimmer image, every shard fails at browser launch with Playwright's missing-libraries error. Fix: either reword the comment to name 8-core-playwright and say its image must stay ubuntu-24.04, or add a cheap guard after the install, such as npx playwright install-deps --dry-run chromium or ldd ~/.cache/ms-playwright/chromium-*/chrome-linux/chrome | grep 'not found' && exit 1. The guard turns an image change into a clear setup failure instead of failed tests.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

# libs, and the apt step it adds can stall for 10+ min on a slow mirror.
- name: Install Playwright browsers
shell: bash
run: cd packages/app && npx playwright install --with-deps chromium
run: cd packages/app && npx playwright install chromium

- name: Start E2E Docker Compose
shell: bash
Expand Down
Loading