Repository navigation
ci(e2e): skip apt deps in Playwright install #3444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 minor — Dropping --with-deps relies on a runner image that nothing in the repo pins
The only caller,
.github/workflows/e2e-tests.yml:11, runs on the larger-runner label8-core-playwright, notubuntu-24.04. That label's OS image is set in the org's runner settings, so the libraries Chromium needs are no longer guaranteed from inside the repo. If someone moves that runner to a newer or slimmer image, every shard fails at browser launch with Playwright's missing-libraries error. Fix: either reword the comment to name8-core-playwrightand say its image must stay ubuntu-24.04, or add a cheap guard after the install, such asnpx playwright install-deps --dry-run chromiumorldd ~/.cache/ms-playwright/chromium-*/chrome-linux/chrome | grep 'not found' && exit 1. The guard turns an image change into a clear setup failure instead of failed tests.Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond