Skip to content

ci(e2e): skip apt deps in Playwright install - #3444

Merged
kodiakhq[bot] merged 1 commit into
mainfrom
warren/e2e-skip-apt-deps
Oct 22, 2026
Merged

kodiakhq[bot] merged 1 commit into
mainfrom
warren/e2e-skip-apt-deps

Conversation

@wrn14897

Copy link
Copy Markdown
Contributor

Summary

E2E setup no longer depends on the Ubuntu apt mirror. In a recent CI run, one shard's setup took 15 minutes because playwright install --with-deps downloaded 23 MB from azure.archive.ubuntu.com at 30 kB/s. The other five shards in that run finished the same step in about 20 seconds.

On this runner image, --with-deps installs nothing the suite uses. The ubuntu-24.04 image already has every library Chromium needs (apt reported each one as "already the newest version"). The step only added CJK, Cyrillic and unifont fonts plus xvfb. Our tests run headless and have no screenshot assertions.

Before After
Install step, browser cache hit ~20s (apt update + dpkg) under 1s
Install step, slow mirror 13+ min, no timeout doesn't use apt

On a browser cache miss, Chromium still downloads from Playwright's CDN, which has its own per-request timeout and retries.

If a future runner image drops a library Chromium needs, the first test fails with Playwright's "missing libraries" error. The fix then is a separate npx playwright install-deps chromium step.

How to test

  1. Check that every E2E shard on this PR passes.
  2. In any shard's "E2E setup" log, check that "Install Playwright browsers" runs no apt-get and finishes in a few seconds.

Compound Engineering
OpenCode

The ubuntu-24.04 runner image already ships Chromium's shared libs, so
--with-deps only installed unused fonts and xvfb. Its apt step stalled one
shard's setup for 13 minutes on a slow Ubuntu mirror.
@vercel

vercel Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
hyperdx-oss Ignored Ignored Preview Oct 22, 2026 9:13pm UTC
hyperdx-storybook Ignored Ignored Preview Oct 22, 2026 9:13pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6c202b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 1
  • Production lines changed: 6
  • Branch: warren/e2e-skip-apt-deps
  • Author: wrn14897

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 116 in total (1.43%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

${{ runner.os }}-playwright-${{
steps.playwright-version.outputs.version }}

# No --with-deps: the ubuntu-24.04 image already ships Chromium's shared

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — Dropping --with-deps relies on a runner image that nothing in the repo pins

The only caller, .github/workflows/e2e-tests.yml:11, runs on the larger-runner label 8-core-playwright, not ubuntu-24.04. That label's OS image is set in the org's runner settings, so the libraries Chromium needs are no longer guaranteed from inside the repo. If someone moves that runner to a newer or slimmer image, every shard fails at browser launch with Playwright's missing-libraries error. Fix: either reword the comment to name 8-core-playwright and say its image must stay ubuntu-24.04, or add a cheap guard after the install, such as npx playwright install-deps --dry-run chromium or ldd ~/.cache/ms-playwright/chromium-*/chrome-linux/chrome | grep 'not found' && exit 1. The guard turns an image change into a clear setup failure instead of failed tests.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

@github-actions

Copy link
Copy Markdown
Contributor

PR Review

If you are a coding agent acting for the author, read this first.
Nothing below blocks merge automatically; a maintainer decides. What they will expect:

  • 🔴 critical or 🟠 major in code this PR adds or changes: fix before asking for review.
  • 🔵 minor in code this PR changes: your call. Fix if small, otherwise reply.
  • Anything about surrounding code, or asking you to widen the change (hoist a helper,
    dedupe with another file, fix other call sites): never fix here, whatever the
    severity. Reply with one sentence; if it is critical, say so plainly so a human sees it.

One commit per review round. After two rounds, stop and ask a maintainer to review
scope rather than addressing more automated findings. Full rule: AGENTS.md.

1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor

1 posted as inline comment(s) on the changed lines.


Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides.

@github-actions

Copy link
Copy Markdown
Contributor

Deep Review

CI-only change: drops --with-deps from npx playwright install chromium in the E2E setup composite action (plus two comment edits). Reviewed against base 0444e3ea. Scope is a single file, .github/actions/e2e-setup/action.yml, consumed by .github/workflows/e2e-tests.yml.

✅ No critical issues found.

The change is sound for its stated goal. Verified independently: the E2E suite runs headless (screenshot: 'only-on-failure', no --headed in CI), has zero visual assertions (no toHaveScreenshot/toMatchSnapshot), so the dropped CJK/Cyrillic/unifont fonts and xvfb cannot affect pass/fail. Removing --with-deps is also a net reliability gain — apt's internal retries were the source of the 10–15 min mirror stall, not a protection worth keeping. The repo's own AGENTS.md already documents playwright install chromium without --with-deps, so the change aligns with existing guidance.

🔵 P3 nitpicks (1)
  • .github/actions/e2e-setup/action.yml:65 — the new comment justifies dropping --with-deps by citing "the ubuntu-24.04 image," but the consuming job runs on the custom self-hosted runner runs-on: 8-core-playwright (.github/workflows/e2e-tests.yml:11), so the stated premise names a runner the suite does not use.
    • Fix: Update the comment to reference the actual 8-core-playwright runner image whose provisioning guarantees Chromium's shared libraries.
    • correctness, reliability, testing, maintainability

Reviewers (5): correctness, reliability, maintainability, project-standards, testing.

Testing gaps:

  • The browser's ability to launch is now entirely delegated to the 8-core-playwright base image; no setup-time smoke check (e.g. a trivial headless Chromium launch) verifies the OS libraries are present, so a future base-image regression would first surface mid-suite across all four shards rather than at the install step. A version-keyed cache hit restores the binary regardless of whether the OS libs exist, which can mask such drift.

No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond

@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable defects were found.

Summary

Removes --with-deps from the Chromium install step to avoid slow Ubuntu package downloads.

  • The E2E setup installs Chromium without asking apt for browser libraries.

Reviews (1) · Last reviewed commit: "ci(e2e): skip apt deps in Playwright ins..." · Reviewed by Greptile

@github-actions

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 459 passed • 1 skipped • 1801s

Status Count
✅ Passed 459
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@kodiakhq
kodiakhq Bot merged commit b2626aa into main Oct 22, 2026
33 checks passed
@kodiakhq
kodiakhq Bot deleted the warren/e2e-skip-apt-deps branch October 22, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants