Repository navigation
ci(e2e): skip apt deps in Playwright install - #3444
Conversation
The ubuntu-24.04 runner image already ships Chromium's shared libs, so --with-deps only installed unused fonts and xvfb. Its apt step stalled one shard's setup for 13 minutes on a slow Ubuntu mirror.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
| ${{ runner.os }}-playwright-${{ | ||
| steps.playwright-version.outputs.version }} | ||
|
|
||
| # No --with-deps: the ubuntu-24.04 image already ships Chromium's shared |
There was a problem hiding this comment.
🔵 minor — Dropping --with-deps relies on a runner image that nothing in the repo pins
The only caller, .github/workflows/e2e-tests.yml:11, runs on the larger-runner label 8-core-playwright, not ubuntu-24.04. That label's OS image is set in the org's runner settings, so the libraries Chromium needs are no longer guaranteed from inside the repo. If someone moves that runner to a newer or slimmer image, every shard fails at browser launch with Playwright's missing-libraries error. Fix: either reword the comment to name 8-core-playwright and say its image must stay ubuntu-24.04, or add a cheap guard after the install, such as npx playwright install-deps --dry-run chromium or ldd ~/.cache/ms-playwright/chromium-*/chrome-linux/chrome | grep 'not found' && exit 1. The guard turns an image change into a clear setup failure instead of failed tests.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
PR Review
1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor 1 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Deep ReviewCI-only change: drops ✅ No critical issues found. The change is sound for its stated goal. Verified independently: the E2E suite runs headless ( 🔵 P3 nitpicks (1)
Reviewers (5): correctness, reliability, maintainability, project-standards, testing. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
[Low impact] The PR appears safe to merge; no actionable defects were found. SummaryRemoves
Reviews (1) · Last reviewed commit: "ci(e2e): skip apt deps in Playwright ins..." · Reviewed by Greptile |
E2E Test Results✅ All tests passed • 459 passed • 1 skipped • 1801s
Tests ran across 4 shards in parallel. |
Summary
E2E setup no longer depends on the Ubuntu apt mirror. In a recent CI run, one shard's setup took 15 minutes because
playwright install --with-depsdownloaded 23 MB fromazure.archive.ubuntu.comat 30 kB/s. The other five shards in that run finished the same step in about 20 seconds.On this runner image,
--with-depsinstalls nothing the suite uses. Theubuntu-24.04image already has every library Chromium needs (apt reported each one as "already the newest version"). The step only added CJK, Cyrillic and unifont fonts plusxvfb. Our tests run headless and have no screenshot assertions.On a browser cache miss, Chromium still downloads from Playwright's CDN, which has its own per-request timeout and retries.
If a future runner image drops a library Chromium needs, the first test fails with Playwright's "missing libraries" error. The fix then is a separate
npx playwright install-deps chromiumstep.How to test
apt-getand finishes in a few seconds.