Repository navigation
Share the Group by split button - #3429
elizabetdev wants to merge 2 commits into
Conversation
Group by needs the same name-and-value button Columns and Sort will use. On a narrow screen a field count is only the number. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 13028a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
PR Review
4 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 4 minor None could be anchored to changed lines; they are listed below. Findings outside the changed lines4 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
[Medium impact] The PR appears safe to merge; the remaining test weakness is non-blocking.
|
Deep Review✅ No critical issues found. This is a clean, well-typed presentational refactor: a new shared 🟡 P2 — recommended
🔵 P3 nitpicks (4)
Reviewers (9): correctness, testing, maintainability, project-standards, kieran-typescript, julik-frontend-races, agent-native, learnings-researcher, previous-comments. Testing gaps: the production No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 457 passed • 1 skipped • 1670s
Tests ran across 4 shards in parallel. |
The frame was stretching in a column layout, so the chevron sat away from the end of the value. Co-authored-by: Cursor <cursoragent@cursor.com>
## Summary Group by uses a new shared split button: a fixed name, then the current value. On a narrow screen a count such as `3 fields` shows as `3`. A single field still shows its name. Columns and Sort will use the same button in a follow-up. This PR only switches Group by, so that button can be reviewed on its own. Storybook (`Components/SplitValueButton`) says when to use it. Related: #3387. Replaces #3429, which closed when the branch moved off the `agent/` prefix. ### Screenshots or video <img width="599" height="436" alt="Screenshot 2026-10-21 at 15 10 27" src="https://github.com/user-attachments/assets/4c40486d-d015-446b-bc45-269851e0772b" /> On the search page: <img width="556" height="99" alt="Screenshot 2026-10-21 at 15 14 15" src="https://github.com/user-attachments/assets/f7f77c13-65d9-48c7-9604-540b1b535b8a" /> ### How to reproduce **Starting point:** Vercel preview, or `yarn app:dev:local` connected to the demo server. **On `main`:** 1. Open Search. 2. Open Group by and select two fields, then Apply. 3. Narrow the window below 900px. The button still reads `2 fields`. **On this branch:** 1. Open Search. 2. Open Group by and select two fields, then Apply. 3. Narrow the window below 900px. The value shows `2`. One field still shows its name, and an empty selection still shows `none`. ### How to test on Vercel preview **Preview routes:** /search **Steps:** 1. Open Group by. 2. Select two fields and click Apply. 3. Verify the button reads Group by and `2 fields` at a desktop width. 4. Narrow the viewport below 900px. 5. Verify the value shows `2`. ### References - Related PR: #3387 Made with [Cursor](https://cursor.com)
Summary
Group by uses a new shared split button: a fixed name, then the current value. On a narrow screen a count such as
3 fieldsshows as3. A single field still shows its name.Columns and Sort will use the same button in a follow-up. This PR only switches Group by, so that button can be reviewed on its own. Storybook (
Components/SplitValueButton) says when to use it.Related: #3387
Screenshots or video
On the search page:

How to reproduce
Starting point: Vercel preview, or
yarn app:dev:localconnected to the demo server.On
main:2 fields.On this branch:
2. One field still shows its name, and an empty selection still showsnone.How to test on Vercel preview
Preview routes: /search
Steps:
2 fieldsat a desktop width.2.References
Made with Cursor