Repository navigation
Share the Group by split button - #3430
Conversation
Group by needs the same name-and-value button Columns and Sort will use. On a narrow screen a field count is only the number. Co-authored-by: Cursor <cursoragent@cursor.com>
The frame was stretching in a column layout, so the chevron sat away from the end of the value. Co-authored-by: Cursor <cursoragent@cursor.com>
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review
4 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 4 minor None could be anchored to changed lines; they are listed below. Findings outside the changed lines4 minor
Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Deep Review✅ No critical issues found. This is a low-risk presentational refactor: it extracts a shared 🟡 P2 -- recommended
🔵 P3 nitpicks (3)
Reviewers (6 returned of 9 dispatched): correctness, testing, maintainability, previous-comments, kieran-typescript, agent-native. The frontend-races, project-standards, and learnings reviewers did not return before output was finalized; independent analysis of the hydration/layout path (benign client-only collapse after mount) and the changeset ( Testing gaps: The production No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
🦋 Changeset detectedLatest commit: ab2df8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
E2E Test Results✅ All tests passed • 456 passed • 1 skipped • 1397s
Tests ran across 4 shards in parallel. |
[Low impact] The PR appears safe to merge; no new actionable issues were found. SummaryExtracts
Reviews (2) · Last reviewed commit: "test(app): require the narrow split butt..." · Reviewed by Greptile |
A substring check for 3 also passed when the label was still 3 fields. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
Group by uses a new shared split button: a fixed name, then the current value. On a narrow screen a count such as
3 fieldsshows as3. A single field still shows its name.Columns and Sort will use the same button in a follow-up. This PR only switches Group by, so that button can be reviewed on its own. Storybook (
Components/SplitValueButton) says when to use it.Related: #3387. Replaces #3429, which closed when the branch moved off the
agent/prefix.Screenshots or video
On the search page:

How to reproduce
Starting point: Vercel preview, or
yarn app:dev:localconnected to the demo server.On
main:2 fields.On this branch:
2. One field still shows its name, and an empty selection still showsnone.How to test on Vercel preview
Preview routes: /search
Steps:
2 fieldsat a desktop width.2.References
Made with Cursor