Repository navigation
chore(dev-portal): group routes by path #3302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 minor — Card label comes from the per-run
worktreename, not the canonical path, so a merged card's name changes with whichever run is newestCards are now grouped by the canonical (realpath) path, but the label still uses
entries[0].worktreehere andcardHeader(stacks).worktreeon the Live tab (line 537).scripts/dev-env.sh:26sets that name tobasename "$PWD", which is the symlink's name.scripts/test-e2e.sh:101andMakefile:38use the basename of the git toplevel instead. Take a checkout opened through a symlink~/hdx -> ~/code/hyperdx: its dev and e2e runs now land in one card, and that card reads "hdx" or "hyperdx" depending on which run sorts first.duplicateNamesthen compares these inconsistent names too. Fix: whenworktreePathis set, usebasename(worktreePath)as the display and duplicate-check name, and fall back toworktreeonly when there is no path. Doing this in the server, right wherecanonicalWorktreePathis applied, means both tabs get it.Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond