Repository navigation
chore(dev-portal): group routes by path - #3302
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
| // Use the first entry for branch info | ||
| function renderHistoryWorktreeCard(key, entries, dupNames) { | ||
| // Use the first entry for branch and worktree info | ||
| const { worktree, worktreePath = '' } = entries[0]; |
There was a problem hiding this comment.
🔵 minor — Card label comes from the per-run worktree name, not the canonical path, so a merged card's name changes with whichever run is newest
Cards are now grouped by the canonical (realpath) path, but the label still uses entries[0].worktree here and cardHeader(stacks).worktree on the Live tab (line 537). scripts/dev-env.sh:26 sets that name to basename "$PWD", which is the symlink's name. scripts/test-e2e.sh:101 and Makefile:38 use the basename of the git toplevel instead. Take a checkout opened through a symlink ~/hdx -> ~/code/hyperdx: its dev and e2e runs now land in one card, and that card reads "hdx" or "hyperdx" depending on which run sorts first. duplicateNames then compares these inconsistent names too. Fix: when worktreePath is set, use basename(worktreePath) as the display and duplicate-check name, and fall back to worktree only when there is no path. Doing this in the server, right where canonicalWorktreePath is applied, means both tabs get it.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
PR Review
1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor 1 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
|
Deep ReviewReport-only multi-agent review of the dev-portal path-grouping change ( ✅ No critical issues found. 🟡 P2 — recommended
🔵 P3 nitpicks (5)
Reviewers (10): correctness, security, adversarial, reliability, maintainability, testing, project-standards, previous-comments, agent-native, learnings-researcher. Testing gaps:
Note: correctness, adversarial, and reliability sub-agents had not returned when the report was finalized; their scope was covered by direct analysis of the full diff. The P2 history-split finding was surfaced that way. Prior PR comments were automated bot notices only (changeset-bot, vercel-bot) — nothing actionable. No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 395 passed • 1 skipped • 1239s
Tests ran across 4 shards in parallel. |
Why
With
HDX_SLOT_FROM=path(#3248), worktrees that share a folder name (a/hyperdx,b/hyperdx) get separate slots and can run at the same time. The portal still grouped cards by folder name, so their stacks were merged into one card.What changed