Skip to content

fix: update favicon and title in index.html for consistency #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Benevanio merged 1 commit into from
Apr 4, 2026
Merged

fix: update favicon and title in index.html for consistency #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<!--C:\Users\benev\projetos\Node\vagas-full\frontend\src\assets\logo-painel-vagas.svg-->

Copilot AI Apr 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the HTML comment containing a local Windows filesystem path. It adds noise to the shipped HTML and leaks developer-specific machine details; if you need a reference, use a repo-relative comment or rely on the actual href path.

Suggested change
<!--C:\Users\benev\projetos\Node\vagas-full\frontend\src\assets\logo-painel-vagas.svg-->

Copilot uses AI. Check for mistakes.
<link rel="icon" type="image/svg+xml" href="/asset/logo-painel-vagas.svg" />

Copilot AI Apr 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The favicon href points to "/asset/logo-painel-vagas.svg", but there is no corresponding file under frontend/public (only favicon.svg/icons.svg). This will 404 in dev/prod. Either keep using "/favicon.svg", move/copy the new SVG into frontend/public and reference it from there, or reference the Vite source asset path correctly (e.g., under /src/assets) per the project's bundling approach.

Suggested change
<link rel="icon" type="image/svg+xml" href="/asset/logo-painel-vagas.svg" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />

Copilot uses AI. Check for mistakes.
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<script>
(function () {
Expand All @@ -19,7 +20,7 @@
root.setAttribute("data-theme", resolvedTheme);
})();
</script>
<title>frontend</title>
<title>Painel de Vagas</title>
</head>
<body>
<div id="root"></div>
Expand Down
Loading