fix: update favicon and title in index.html for consistency - #53
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Updates the frontend’s static HTML entrypoint to align the browser tab title and favicon with the “Painel de Vagas” branding.
Changes:
- Changed the document title to “Painel de Vagas”.
- Replaced the favicon link target (and added an inline comment) to point to a logo SVG.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/favicon.svg" /> | ||
| <!--C:\Users\benev\projetos\Node\vagas-full\frontend\src\assets\logo-painel-vagas.svg--> |
There was a problem hiding this comment.
Remove the HTML comment containing a local Windows filesystem path. It adds noise to the shipped HTML and leaks developer-specific machine details; if you need a reference, use a repo-relative comment or rely on the actual href path.
| <!--C:\Users\benev\projetos\Node\vagas-full\frontend\src\assets\logo-painel-vagas.svg--> |
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/favicon.svg" /> | ||
| <!--C:\Users\benev\projetos\Node\vagas-full\frontend\src\assets\logo-painel-vagas.svg--> | ||
| <link rel="icon" type="image/svg+xml" href="/asset/logo-painel-vagas.svg" /> |
There was a problem hiding this comment.
The favicon href points to "/asset/logo-painel-vagas.svg", but there is no corresponding file under frontend/public (only favicon.svg/icons.svg). This will 404 in dev/prod. Either keep using "/favicon.svg", move/copy the new SVG into frontend/public and reference it from there, or reference the Vite source asset path correctly (e.g., under /src/assets) per the project's bundling approach.
| <link rel="icon" type="image/svg+xml" href="/asset/logo-painel-vagas.svg" /> | |
| <link rel="icon" type="image/svg+xml" href="/favicon.svg" /> |
No description provided.