Skip to content

fix(review): describe recorded-operation fallbacks honestly - #2655

Merged
Chris0Jeky merged 1 commit into
mainfrom
issue-1434/fallback-banner
Sep 5, 2026
Merged

fix(review): describe recorded-operation fallbacks honestly#2655
Chris0Jeky merged 1 commit into
mainfrom
issue-1434/fallback-banner

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • make the Legacy terminal-review banner describe the actual content mode
  • say “recorded operations” for the local fallback and “no stored preview is available” for an empty terminal record
  • preserve the original-submission wording when a real stored preview is present

The PaperReviewView counterpart is intentionally out of scope because its shared path is leased by open PR #2629.

Verification

pm test -- --maxWorkers=2 src/tests/components/review/ReviewProposalCard.diff.spec.ts — 21 passed

pm run typecheck — passed

  • scoped ESLint — passed
  • git diff --check — passed

Refs #1434

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Review gate (Codex review credits exhausted, SC-9; D-12 ruled 2026-09-05: the Codex session's PRs are reviewed and merged by the coordinator): one fresh-context read-only reviewer (Opus 5) on head e9858f0d2. Verdict: SHIP.

Checked by reading: the three wording branches of readOnlyDiffBanner map exactly to the three template modes (selectedDiff, storedOperationsFallback, the empty span) with the same truthiness tests; the banner renders only under selectedDiffMode === 'stored'; the status prefix still reads isExpired; no i18n key added or changed (this Legacy card is hardcoded English throughout, and the localized Paper counterpart is untouched, consistent with the body deferring it to #2629); the two new not.toContain assertions fail on revert; no new em dash beyond the preserved pre-existing prefix.

Findings and disposition:

  • LOW, tracked on #1434: the fallback banner now repeats the note rendered directly below it.

Issue disposition: slice of #1434 (Legacy card only); the Paper surface still shows the unconditional banner in all three locales.

@Chris0Jeky
Chris0Jeky merged commit e4b15d6 into main Sep 5, 2026
35 checks passed
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 5, 2026
@Chris0Jeky
Chris0Jeky deleted the issue-1434/fallback-banner branch September 6, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant