Paper/Legacy stored-preview presentation parity (recorded-ops format, banner wording, Applied label)

[Chris0Jeky]

Summary

The stored-preview presentation added for #1397 / #1414 (present a terminal/expired proposal's stored diffPreview under a read-only banner instead of a live /diff) diverges between the Paper shell (PaperReviewView.vue) and the Legacy shell (useReviewActions.ts + ReviewProposalCard.vue). All three are pre-existing, cosmetic/copy-only (no correctness or security impact), and were surfaced by a two-lens adversarial review during the #1414 P2 round but left out of that PR's diff as out-of-scope. Tracking here per ADR-0038 (Paper/Legacy no-drift).

Findings

1. Recorded-operations fallback formatting differs across shells (MEDIUM)

This is the common expired path (normal creation flows don't populate diffPreview, so both shells synthesize a listing from the proposal's operations).

• Paper (frontend/taskdeck-web/src/views/paper/PaperReviewView.vue:233): `${i}. ${formatActionLabel(op.actionType)} · ${op.targetType}…` → "1. Create Card · Card".
• Legacy (frontend/taskdeck-web/src/components/review/ReviewProposalCard.vue:54): `${i}. ${op.actionType} ${op.targetType}…` → "1. CreateCard Card".

Different label transform (formatActionLabel vs raw actionType) AND separator (· vs space). The same expired proposal reads differently depending on shell. Specs currently bake in the drift (Paper spec asserts 'Create Card'; Legacy spec asserts /1\. CreateCard Card/), so aligning requires updating one shell's format + its spec. Suggested canonical: Paper's formatActionLabel + · (more human-readable; Paper is the go-forward shell).

2. Paper banner claims "stored preview" while showing the synthesized recorded-ops fallback (LOW/MEDIUM)

• Legacy renders an explicit note above its fallback (ReviewProposalCard.vue:246-248): "No stored preview was captured — showing the proposal's recorded operations."
• Paper's non-revised fallback (PaperReviewView.vue:1133-1139) has no such note, yet the banner (PaperReviewView.vue:1076) still reads "…showing the stored preview from the original submission" — inaccurate for the recorded-ops fallback (which is synthesized, not a stored preview). Paper does clarify in the revised case (revised-note); only the non-revised case is mislabeled. Add the same clarifying note to Paper for copy accuracy + parity.

3. Banner status wording drift for Applied (LOW)

• Paper previewReadOnlyLabel (PaperReviewView.vue:216) uses the raw normalized status → "Applied".
• Legacy uses reviewStatusLabel (ReviewProposalCard.vue:211) → "Applied to board".
  Expired/Rejected/Failed/Dismissed labels match; only Applied diverges.

Scope / non-goals

Cosmetic + copy parity only. No behavior, correctness, or access-control change. When picking a canonical form, keep the shared-rule direction (ADR-0038) so the two shells converge rather than each keeping its own idiom.

References

• PR Present expired proposals via stored preview instead of a live diff that 400s (#1397) #1414 (the P2 round that surfaced these during the pre-fix comprehensive sweep).
• Issue Expired/zero-op proposals: graceful preview presentation + frontend coverage for the new diff 400 contract #1397 (the stored-preview-for-terminal-proposals feature).

[Chris0Jeky]

Codex lane claim

I am taking the bounded TD-1434-fallback-banner row on the Legacy ReviewProposalCard surface only. When a terminal proposal has no stored diffPreview, the card already renders its recorded operations, but the read-only banner still says it is showing a stored preview. I will make that banner honest and add focused coverage. The PaperReviewView counterpart remains out of scope because its shared path is currently leased by open PR #2629.

[Chris0Jeky]

Codex lane release

• Slice: TD-1434-fallback-banner
• PR: fix(review): describe recorded-operation fallbacks honestly #2655 (fix(review): describe recorded-operation fallbacks honestly #2655)
• Exact head: �9858f0d2f7db43fef08141a8f5f80a865adb28e
• Scope: Legacy ReviewProposalCard only. The terminal banner now distinguishes a real stored preview, recorded-operation fallback, and no stored preview. PaperReviewView was intentionally not changed because PR fix: guard deferred review receipts by decision locus #2629 leases that path.
• Verification: focused suite 21/21, three repeated focused runs 21/21 each,
  pm run typecheck, scoped ESLint, and git diff --check passed.
• Review: two coordinator passes were clean (scope/branch correctness; adversarial three-mode and path-lease checks). Hosted Codex review is unavailable because the account review quota is exhausted.

PR is open and ready for review. This does not close #1434; the Paper parity and Applied-label rows remain separate.

[Chris0Jeky]

Coordinator note (2026-09-05, D-12 sweep): the Codex session's PR on this issue was reviewed by one fresh-context Opus 5 reviewer (record on the PR) and merged with a merge commit. The PR body used Refs, so this issue stays open; what merged and what remains, from the review:

• PR #2655 merged as e4b15d67d: the Legacy ReviewProposalCard terminal-review banner names the actual content mode (stored preview, recorded operations, or no stored preview). Remaining: the Paper surface still shows the unconditional "stored preview from the original submission" banner in all three locales (review.diff.storedBanner), which the PR deferred while #2629 held PaperReviewView.vue; that PR is merged, so the path is free. LOW: the fallback banner now repeats the note rendered directly below it.

[Chris0Jeky]

[Claude lane claim v2]
lane: alpha-product-trust (session taskdeck-alpha-85, Taskdeck-Alpha checkout)
issue: #1434
base: origin/main at claim time (f6071dc or later, after the lane's PR #2694 released PaperReviewView.vue)
residual acceptance: the Paper half the coordinator recorded on 2026-09-05 after PR #2655 landed the Legacy banner: (1) finding 2, the Paper stored-preview banner (review.diff.storedBanner, rendered unconditionally whenever previewDiffMode === 'stored' in PaperReviewView.vue ~2810-2816) names the actual content mode the way the Legacy card now does: a stored preview from the original submission, the proposal's recorded operations when no preview was captured (the synthesized fallback the issue calls the common expired path), or no stored preview at all; the copy converges on the Legacy wording (ADR-0038 shared-rule direction) through keys in en, es and it, with the existing revised-proposal caveat's stored/fallback tails kept consistent with the banner; (2) finding 3, the Applied status label: Paper's previewReadOnlyLabel renders the raw normalized status ("Applied") while Legacy renders "Applied to board" through reviewStatusLabel; converge on the Legacy form by reusing the same label helper if it is importable without a new dependency direction, otherwise the same catalog key; (3) the LOW the coordinator noted on the Legacy side (the fallback banner repeating the note rendered directly below it) is checked on the Paper side and the Paper banner does not duplicate a note already on screen. Specs, red-first, in PaperReviewView.spec.ts: the banner copy per content mode (stored preview, recorded-operations fallback, none), the Applied label parity, and the catalog parity for the new keys; the Legacy card's ReviewProposalCard.diff.spec.ts assertions stay green (read only unless a shared key moves). Finding 1 (recorded-operations fallback formatting parity) is checked against main first: if PR #2655 or an earlier PR already converged it, say so on the issue; if not, it joins this slice only if it is a copy-only change in the same two files.
owned paths/modules: frontend/taskdeck-web/src/views/paper/PaperReviewView.vue (the diff pane's banner and the read-only label computed only); src/locales/{en,es,it}/review.ts (review.diff.* keys); src/tests/views/paper/review/PaperReviewView.spec.ts; src/components/review/ReviewProposalCard.vue and its diff spec only if a key is shared and must move. NOT owned: useReviewProposals.ts, useReviewActions.ts, usePaperReviewSelectors.ts, ReviewMain.vue, the receipt recorders and the poll disclosures in PaperReviewView.vue (PRs #2692 and #2694)
shared-path leases: none; PR #2694 merged f6071dc and released PaperReviewView.vue and the review locales; no open PR touches them or the Legacy card (checked gh pr list files at claim time)
parallel-safe work: #2696 (#1871, inbox files) is disjoint and waits on CI
open PRs/branches/review threads checked: both claim forms on #1434 (the Codex TD-1434-fallback-banner claim released 2026-09-05T06:08 with PR #2655; nothing since the coordinator's 13:54 residual comment); PRs #1414, #2655 merged
human or decision gates: none
status: active (worktree codex-1434-paper-banner at f6071dc)