Skip to content

test: drain review cleanup callbacks - #2622

Open
Chris0Jeky wants to merge 1 commit into
mainfrom
issue-2578/cleanup-stack
Open

test: drain review cleanup callbacks#2622
Chris0Jeky wants to merge 1 commit into
mainfrom
issue-2578/cleanup-stack

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Refs #2578

Summary

  • Make the ReviewDecisionRail and ReviewMain cleanup stacks drain every callback even when one cleanup throws.
  • Preserve LIFO teardown order and surface one failure or aggregate multiple failures after cleanup completes.
  • Add direct regression coverage for the throwing-cleanup path in both affected review specs.

Verification

  • Targeted ReviewDecisionRail + ReviewMain tests: 47/47
  • Frontend unit suite: 5,710 passed, 3 skipped across 370 files
  • Frontend typecheck: passed
  • File-scoped ESLint: passed
  • Mutation check: immediate rethrow caused the new test to fail because the earlier cleanup was skipped; helper restored and suite passed.
  • git diff --check: passed

Two coordinator review passes completed for failure-path correctness and scope/regression quality.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending

Development

Successfully merging this pull request may close these issues.

1 participant