fix(deploy): prod compose actually persists Y.Doc rooms#228
Open
schnsrw wants to merge 1 commit into
Open
Conversation
The prod compose commented "persist Y.Doc room snapshots" but only set CASUAL_STORAGE (the file host) — Y.Doc ROOM storage is selected by REDIS_URL, which was commented out, so live rooms ran in-memory and were dropped on every restart. Adds a redis service (with RDB persistence + healthcheck) and wires REDIS_URL/CASUAL_REDIS_PREFIX so rooms actually survive restarts. Also sets NODE_ENV=production (activating the collab server's new refuse-to-boot guard against ephemeral prod storage) and TRUST_PROXY=true (Caddy terminates TLS, so per-IP rate limiting must key off the forwarded client IP). Adds an app healthcheck hitting /health so the proxy waits for readiness. Pairs with CasualOffice/collab#4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prod compose promised "persist Y.Doc room snapshots" in a comment but only set
CASUAL_STORAGE(the file host); Y.Doc room storage is selected byREDIS_URL, which was commented out — so live rooms ran in-memory and were dropped on every restart.redisservice (RDB persistence + healthcheck) and wiresREDIS_URL/CASUAL_REDIS_PREFIXso rooms survive restarts.NODE_ENV=production(activates the collab server's new refuse-to-boot guard against ephemeral prod storage) andTRUST_PROXY=true(Caddy terminates TLS, so per-IP rate limiting must key off the forwarded client IP)./healthhealthcheck so the proxy waits for readiness.Pairs with CasualOffice/collab#4 (the server-side durability + security fixes).
docker compose configvalidates.