fix(defaults): factory colorMode theme instead of rainbow - #687
Merged
Merged
Conversation
Visualizer (and surfaces that bind to visualizer.colorMode: text, now-playing, layers) now factory-default to color theme so gradient presets/templates apply out of the box. Background was already theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Factory-default
visualizer.colorModeis now theme (color theme) instead of rainbow, so color presets/templates apply on a fresh install. Background was alreadytheme. Text, now-playing, and layers that bind tovisualizer.colorModeinherit this default.Keys changed
visualizer.colorMode'rainbow''theme'visualizer.rainbowtruefalsebackground.colorMode'theme'(unchanged)'theme'Geometry
colorMode: 'palette'and lighting rainbow-* mode settings are unrelated and unchanged.Tests
tests/background-color-mode.test.jsbackground-color-mode,config,layers-config-cost,layer-draw-error,templates)Why
Rainbow ignored the shared palette / gradient presets. Theme mode makes color templates matter out of the box.