feat(layers): add Now Playing as first-class layer kind - #688
Merged
Merged
Conversation
Add nowplaying alongside media/visualizer/sprites/logo in the layer stack: KINDS, add-row button, makeNowPlayingLayer, layerConfig/_create/ draw reuse SVModes.nowplaying cover/title. i18n already maps Çalan Parça → Now Playing. Tests + badge 2552.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Now Playing / Çalan Parça as a first-class layer kind in the layer stack, alongside background, visualizer, media, sprites, and logo.
What changed
SVLayers.KINDS+makeNowPlayingLayer()— factory withsettings.nowplaying(cover/title via existingSVModes.nowplaying)layerConfig/_create/ draw treatkind === 'nowplaying'like the existing nowplaying visualizer modeWhy
With the layer stack on, the dedicated Now Playing card is hidden (
notStack). Users could only reach it by adding a Visualizer and switching type. A dedicated kind makes cover/title overlays easy to stack and order.Related
Follows #687 (factory
colorMode: theme) so NP layers pick up color presets by default.