Move Cb, Cs, and Cu to kpp_params_type#109
Merged
mnlevy1981 merged 1 commit intoCVMix:masterfrom Oct 20, 2025
Merged
Conversation
Also renamed them ER_Cb, ER_Cs, and ER_Cu, respectively. They can now we set by the GCM when calling cvmix_kpp_init(). For testing, I modified my local run_test_suite.sh to use "--strict exact" and was able to confirm that these changes are bit-for-bit (as expected).
Contributor
Author
|
@gustavo-marques next week, let's talk about testing this in a MOM6 sandbox -- we need to add three variables to the MOM6 parameters file and then modify the call to |
Contributor
|
Sounds good! Thanks @mnlevy1981 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also renamed them
ER_Cb,ER_Cs, andER_Cu, respectively. They can now we set by the GCM when callingcvmix_kpp_init().For testing, I modified my local
run_test_suite.shto use--strict exactand was able to confirm that these changes are bit-for-bit (as expected).Fixes #108